Add wandb to rsmexplain and rsmxval #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #627 +/- ##
=======================================
Coverage 95.87% 95.88%
=======================================
Files 60 60
Lines 9357 9378 +21
=======================================
+ Hits 8971 8992 +21
Misses 386 386
☔ View full report in Codecov by Sentry. |
tamarl08
requested review from
desilinguist,
damien2012eng and
mulhod
and removed request for
desilinguist and
damien2012eng
tamarl08
changed the title
mulhod
reviewed
Jul 31, 2023
added 8 commits
July 31, 2023 10:27
…n rsmxval/explain
…n rsmxval/explain
desilinguist
force-pushed
the
597-wandb-explain-xval
branch
from
8b7bcec
to
310eedd
Compare
desilinguist
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
I tried out the rsmexplain and rsmxval tutorial and they both work great. The rsmxval one was a bit on the slow side but I figured that was because there was a lot to log.
It would be nice to log more intermediate files from both tools but that can be an additional issue.
mulhod
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the option to pass a wandb_run object to all modules - that allows rsmxval to use a single object and also will allow passing it from external runs which can be useful.
Note that at this point rsmxval do not log the folds report and intermediate files, it will require additional handling.
rsmexplain logs only the final report, we can discuss which additional output/input files could be helpful to log.
See run examples for xval and explain