Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre-commit checks #647

Merged
merged 3 commits into from
Aug 21, 2023
Merged

Update pre-commit checks #647

merged 3 commits into from
Aug 21, 2023

Conversation

desilinguist
Copy link
Member

This PR:

  • updates the pre-commit checks to their latest versions
  • updates contributing.md to use correct pre-commit install command

To test this, check out this branch and run the command in contributing.md. Then try to make a commit with a random commit message, it should fail.

@tamarl08
Copy link
Contributor

tested, works! and I see the guidelines when getting the error message, but still worth mentioning it somewhere in the docs.

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4c1a737) 95.81% compared to head (2d46cfa) 95.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #647   +/-   ##
=======================================
  Coverage   95.81%   95.81%           
=======================================
  Files          32       32           
  Lines        4444     4444           
=======================================
  Hits         4258     4258           
  Misses        186      186           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@desilinguist
Copy link
Member Author

@tamarl08 I updated the docs to link to the commit specification.

@desilinguist desilinguist merged commit 49ebb6d into main Aug 21, 2023
9 checks passed
@delete-merged-branch delete-merged-branch bot deleted the update-pre-commit-checks branch August 21, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants