align Interrupt apis and add optional interruption to async api

[jessekelly881]

Effect.async and Effect.asyncInterrupt can be merged into 1 function.

[changeset-bot]

🦋 Changeset detected

Latest commit: f247355

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@effect/io	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[IMax153]

@jessekelly881 - I'm not sure this is a good idea.

Returning void | Effect risks hard to find bugs, for example it completely allows a user to do:

Effect.async((resume) => {
  // no `return` statement
  Effect.sync(() => {})
})

cc @mikearnaldi for further input

[jessekelly881]

True. The most "correct" return type would probably be Option<Effect>. But.. that would be awkward to work with when not returning a value.

[mikearnaldi]

I kind of like it tbh, dangling & unassigned effects could be flagged by an eslint plugin, this isn't the only case, for example logging in a generator has the same issue

[tim-smart]

I quite like this too :)

Will take a look at moving this forward shortly.

[jessekelly881]

Damn that was fast. Jaja. Looks good. :)

[tim-smart]

@mikearnaldi Aligned the *Interrupt apis to use AbortSignal, and renamed asyncEither.

I wonder if they should be called asyncAbort, tryPromiseAbort instead.

[mikearnaldi]

@mikearnaldi Aligned the *Interrupt apis to use AbortSignal, and renamed asyncEither.

I wonder if they should be called asyncAbort, tryPromiseAbort instead.

I don't think so we should not have two names for interrupt they are semantically the same thing

[tim-smart]

I don't think so we should not have two names for interrupt they are semantically the same thing

Cool, will stick with interrupt.