Skip to content
This repository has been archived by the owner on Jul 16, 2024. It is now read-only.

Add Scheduler hotfix for Bun #662

Merged
merged 5 commits into from
Sep 15, 2023
Merged

Add Scheduler hotfix for Bun #662

merged 5 commits into from
Sep 15, 2023

Conversation

fubhy
Copy link
Member

@fubhy fubhy commented Sep 11, 2023

I ran into this issue in this particular case (Scheduled.ts) in #661

There's other places in our code base where we utilize setTimeout that can conceivably be called with a 0 interval. We might want to fix this globally or just ignore it until Bun fixes this in their runtime.

This has already been reported in Bun: oven-sh/bun#3333

@changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2023

🦋 Changeset detected

Latest commit: 2dbe149

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@effect/io Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

src/Scheduler.ts Outdated Show resolved Hide resolved
@mikearnaldi mikearnaldi merged commit c43d4aa into main Sep 15, 2023
1 check passed
@mikearnaldi mikearnaldi deleted the fix-bun branch September 15, 2023 09:49
@github-actions github-actions bot mentioned this pull request Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants