Schema: split should support subtypes of string (#512)

Effect-TS · Oct 25, 2023 · c1beed7 · c1beed7
1 parent 3d2e2b0
commit c1beed7
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 4 deletions.
diff --git a/.changeset/flat-ears-trade.md b/.changeset/flat-ears-trade.md
@@ -0,0 +1,5 @@
+---
+"@effect/schema": patch
+---
+
+Schema: `split` should support subtypes of `string`
diff --git a/dtslint/Schema.ts b/dtslint/Schema.ts
@@ -630,3 +630,11 @@ S.string.pipe(S.transformOrFail(S.number, s => ParseResult.success(s), n => Pars
 
 // @ts-expect-error
 S.string.pipe(S.transformOrFail(S.number, s => ParseResult.success(s.length), n => ParseResult.success(n)))
+
+// ---------------------------------------------
+// split
+// ---------------------------------------------
+
+// should support subtypes of `string`
+// $ExpectType Schema<`a${string}`, readonly string[]>
+S.templateLiteral(S.literal('a'), S.string).pipe(S.split(':'))
diff --git a/src/Schema.ts b/src/Schema.ts
@@ -1790,16 +1790,17 @@ export const trim = <I, A extends string>(self: Schema<I, A>): Schema<I, A> =>
  * @since 1.0.0
  */
 export const split: {
-  (separator: string): <I>(self: Schema<I, string>) => Schema<I, ReadonlyArray<string>>
-  <I>(self: Schema<I, string>, separator: string): Schema<I, ReadonlyArray<string>>
+  (separator: string): <I, A extends string>(self: Schema<I, A>) => Schema<I, ReadonlyArray<string>>
+  <I, A extends string>(self: Schema<I, A>, separator: string): Schema<I, ReadonlyArray<string>>
 } = dual(
   2,
-  <I>(self: Schema<I, string>, separator: string): Schema<I, ReadonlyArray<string>> =>
+  <I, A extends string>(self: Schema<I, A>, separator: string): Schema<I, ReadonlyArray<string>> =>
     transform(
       self,
       array(string),
       S.split(separator),
-      ReadonlyArray.join(separator)
+      ReadonlyArray.join(separator),
+      { strict: false }
     )
 )