ci: optimize build #242
Merged
ci: optimize build #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sljeff
force-pushed
the
ci/optimize-build
branch
9 times, most recently
from
2939a3d
to
36730a6
Compare
Ehco1996
reviewed
Oct 11, 2023
| @@ -17,7 +17,7 @@ FAIL_ON_STDOUT := awk '{ print } END { if (NR > 0) { exit 1 } }' | |||
| # -w -s 参数的解释：You will get the smallest binaries if you compile with -ldflags '-w -s'. The -w turns off DWARF debugging information | |||
| # for more information, please refer to https://stackoverflow.com/questions/22267189/what-does-the-w-flag-mean-when-passed-in-via-the-ldflags-option-to-the-go-comman | |||
| # we need CGO_ENABLED=1 because we import the node_exporter ,and we need install `glibc-source,libc6` to make it work | |||
There was a problem hiding this comment.
开了 cgo 是因为内置了 node_exporter ,prometheus/node_exporter#400
There was a problem hiding this comment.
之后调研一下哪些 collector 需要开 cgo 编译，暂时先合并了 感谢 jeff @sljeff
sljeff
force-pushed
the
ci/optimize-build
branch
from
36730a6
to
dc53060
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cd 的改动暂时放在.github/workflows/optimize-build.yaml里方便推分支的时候测试，没问题的话就迁移到 cd.yaml 里去改动
cd.Dockerfile然后还有这些被迫的改动：
CGO_ENABLED=0，因为 CGO 开了不能交叉编译RUN chmod +x ehco因为不知道为啥拷过去的二进制没有执行权限效果
cd 总时间从十几分钟缩短到四分钟
同样 tag 的镜像是多平台的（不过我没有 arm 的 linux 设备可以测试）