Conditionally add break after multiline code block #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, i was only incremented once for the multiline code block
start marker, which would cause the three it to be interpreted as
multiline-start, inline-start, inline-close. For example, the message
```hello```
would be rendered as
<br/><span style='font-family: monospace; white-space: pre'><span style='font-family: monospace; white-space: pre'></span>hello</span>
This commit fixes the issue by incrementing i to the end of the start
marker.
Signed-off-by: Kevin Locke <[email protected]>
In the Discord web client (and presumably others) multiline code blocks are rendered using `<pre><code>text</code></pre>`. Since `<pre>` is a block-level element, the text is always displayed on its own line(s). Mimic this behavior by adding a line break when text following the block would appear on the same line. Ignore collapsible white space, as a browser would. Fixes: EionRobb#207 Signed-off-by: Kevin Locke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Discord web client (and presumably others) multiline code blocks are rendered using
<pre><code>text</code></pre>. Since<pre>is a block-level element, the text is always displayed on its own line(s). Mimic this behavior by adding a line break when text following the block would appear on the same line. Ignore collapsible white space, as a browser would.This PR includes a small fix for duplicate markup at the start of multiline code blocks. I can split that into a separate PR if you'd prefer.
Thanks,
Kevin
Fixes: #207