forked from angular/components
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(tabs): observing tab header label changes to recalculate width
- Uses observe-changes directive that emit an event when the mutation observer notifies a change fixes angular#2155
- Loading branch information
1 parent
2897b9b
commit f839831
Showing
7 changed files
with
138 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
import {Component} from '@angular/core'; | ||
import {async, TestBed} from '@angular/core/testing'; | ||
import {ObserveContentModule} from './observe-content'; | ||
|
||
// TODO(elad): `ProxyZone` doesn't seem to capture the events raised by `MutationObserver` and needs to be investigated | ||
|
||
describe('Observe content', () => { | ||
beforeEach(async(() => { | ||
TestBed.configureTestingModule({ | ||
imports: [ObserveContentModule], | ||
declarations: [ComponentWithTextContent, ComponentWithChildTextContent], | ||
}); | ||
|
||
TestBed.compileComponents(); | ||
})); | ||
|
||
describe('text content change', () => { | ||
it('should call the registered for changes function', done => { | ||
let fixture = TestBed.createComponent(ComponentWithTextContent); | ||
fixture.detectChanges(); | ||
|
||
// If the hint label is empty, expect no label. | ||
const spy = spyOn(fixture.componentInstance, 'doSomething').and.callFake(() => { | ||
expect(spy.calls.any()).toBe(true); | ||
done(); | ||
}); | ||
|
||
expect(spy.calls.any()).toBe(false); | ||
|
||
fixture.componentInstance.text = 'text'; | ||
fixture.detectChanges(); | ||
}); | ||
}); | ||
|
||
describe('child text content change', () => { | ||
it('should call the registered for changes function', done => { | ||
let fixture = TestBed.createComponent(ComponentWithChildTextContent); | ||
fixture.detectChanges(); | ||
|
||
// If the hint label is empty, expect no label. | ||
const spy = spyOn(fixture.componentInstance, 'doSomething').and.callFake(() => { | ||
expect(spy.calls.any()).toBe(true); | ||
done(); | ||
}); | ||
|
||
expect(spy.calls.any()).toBe(false); | ||
|
||
fixture.componentInstance.text = 'text'; | ||
fixture.detectChanges(); | ||
}); | ||
}); | ||
}); | ||
|
||
|
||
@Component({ template: `<div (cdk-observe-content)="doSomething()">{{text}}</div>` }) | ||
class ComponentWithTextContent { | ||
text = ''; | ||
doSomething() {} | ||
} | ||
|
||
@Component({ template: `<div (cdk-observe-content)="doSomething()"><div>{{text}}<div></div>` }) | ||
class ComponentWithChildTextContent { | ||
text = ''; | ||
doSomething() {} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
import { | ||
Directive, | ||
ElementRef, | ||
NgModule, | ||
ModuleWithProviders, | ||
Output, | ||
EventEmitter, | ||
OnDestroy, | ||
AfterContentInit | ||
} from '@angular/core'; | ||
|
||
@Directive({ | ||
selector: '[cdk-observe-content]' | ||
}) | ||
export class ObserveContent implements AfterContentInit, OnDestroy { | ||
private _observer: MutationObserver; | ||
|
||
@Output('cdk-observe-content') event = new EventEmitter<void>(); | ||
|
||
constructor(private _elementRef: ElementRef) {} | ||
|
||
ngAfterContentInit() { | ||
this._observer = new MutationObserver(mutations => mutations.forEach(() => this.event.emit())); | ||
|
||
this._observer.observe(this._elementRef.nativeElement, { | ||
characterData: true, | ||
childList: true, | ||
subtree: true | ||
}); | ||
} | ||
|
||
ngOnDestroy() { | ||
this._observer.disconnect(); | ||
} | ||
} | ||
|
||
@NgModule({ | ||
exports: [ObserveContent], | ||
declarations: [ObserveContent] | ||
}) | ||
export class ObserveContentModule { | ||
static forRoot(): ModuleWithProviders { | ||
return { | ||
ngModule: ObserveContentModule, | ||
providers: [] | ||
}; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters