Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use line length of 100 #140

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Use line length of 100 #140

merged 2 commits into from
Aug 1, 2023

Conversation

jayvdb
Copy link
Collaborator

@jayvdb jayvdb commented Jul 31, 2023

These lines were not being reformatted.
To find them, nightly rustfmt is needed using rust-lang/rustfmt#3391

Is this worth the blame changes?
If so, should I also add CI to install nightly rustfmt and check with that option?

@Electron100
Copy link
Owner

I'm fine with the blame changes.
Putting nightly rustfmt with error_on_line_overflow in CI seems nice-to-have, but hardly mission critical.

@jayvdb jayvdb merged commit 43d96bf into Electron100:master Aug 1, 2023
1 check passed
@jayvdb jayvdb deleted the line-length-100 branch August 1, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants