Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

Add use cases for Crop Rotation #1292

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hatchla
Copy link
Contributor

@hatchla hatchla commented Apr 16, 2024

Basics

  • The PR is rebased with current master
  • I added a line to changelog.md
  • Details of what I changed are in the commit messages
  • References to issues, e.g. close #X, are in the commit messages and changelog
  • The buildserver is happy

Checklist

  • I fully described what my PR does in the documentation
  • I fixed all affected documentation
  • I fixed the introduction tour
  • I wrote migrations in a way that they are compatible with already present data
  • I fixed all affected decisions
  • I added automated tests or a manual test protocol
  • I added code comments, logging, and assertions as appropriate
  • I translated all strings visible to the user
  • I mentioned every code or binary not directly written or done by me in reuse syntax
  • I created left-over issues for things that are still to be done
  • Code is conforming to our Architecture
  • Code is conforming to our Guidelines
  • Code is consistent to our Design Decisions
  • Exceptions to any guidelines are documented

First Time Checklist

Review

  • I've tested the code
  • I've read through the whole code
  • I've read through the whole documentation
  • I've checked conformity to guidelines
  • I've checked conformity to requirements
  • I've checked that the requirements are tested

@hatchla hatchla requested a review from markus2330 April 16, 2024 13:20
@hatchla hatchla self-assigned this Apr 16, 2024
@hatchla hatchla linked an issue Apr 16, 2024 that may be closed by this pull request
3 tasks
@hatchla
Copy link
Contributor Author

hatchla commented Apr 16, 2024

Is there something missing here still and what do you think about this draft? @markus2330

@hatchla
Copy link
Contributor Author

hatchla commented Apr 21, 2024

@markus2330 Could you please give me some feedback on this or should I just convert it to a real pool request instead of having it as a draft because its roughly ok as it already and ready for normal reviews?

Copy link
Contributor

@markus2330 markus2330 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed in meeting

- **Scope:** Crop Rotation
- **Level:** User Goal
- **Actors:** App User
- **Brief:** The user gets information for selecting plant locations based on removed plants and their compatibility.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean with "selecting plant locations", I think this is another use case?

Suggested change
- **Brief:** The user gets information for selecting plant locations based on removed plants and their compatibility.
- **Brief:** The user gets information based on earlier or later plants for each location.

- **Main success scenario:**
- The user performs the scenario from the use case [Heatmap](../current/heatmap_layer.md) or [Relation Layer](../current/relation_layer.md).
- Within the process of selecting a location to plant/move a plant the visual indications are improved as follows:
- Additional to the information these two already have by themselves, the following features extend them by adding to its knowledge base:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us make it better understandable: they don't have information "by themselves", but we list all use cases of these layers and all information is described in separate use cases.

- **Level:** User Goal
- **Actors:** App User
- **Brief:** The user gets information for selecting plant locations based on removed plants and their compatibility.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to assigned and assign yourself.

- **Precondition:**
- The user has opened the app and selected the Planting Layer.
- **Main success scenario:**
- The user performs the scenario from the use case [Heatmap](../current/heatmap_layer.md) or [Relation Layer](../current/relation_layer.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't double redirect.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Use Cases for Crop Rotation
2 participants