Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

db schemata for seeds #22

Merged
merged 21 commits into from
Jan 17, 2023
Merged

db schemata for seeds #22

merged 21 commits into from
Jan 17, 2023

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Jan 9, 2023

naming and data types can still be improved for sure

@buenaflor
Copy link
Contributor Author

buenaflor commented Jan 9, 2023

whoops, seems like there is a problem on GitHub rendering the er diagram, I'll take a look at it.

edit: should be good now

Copy link
Contributor

@markus2330 markus2330 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

doc/architecture/database_schemata.md Show resolved Hide resolved
doc/architecture/database_schemata.md Outdated Show resolved Hide resolved
doc/architecture/database_schemata.md Outdated Show resolved Hide resolved

```sql
CREATE TYPE tag AS ENUM (
'Leaf crops',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will the translation work? Probably put the translation as a comment for now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, good point. This could be done in many ways, for example in the service layer translating to German after querying the db or directly in the db. I'll comment it for now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there are only a few occurrences in these enums, it probably should be translated like other UI text.

Translating the whole database will be the more interesting challenge.

doc/architecture/database_schemata.md Outdated Show resolved Hide resolved
doc/architecture/database_schemata.md Outdated Show resolved Hide resolved
doc/architecture/database_schemata.md Outdated Show resolved Hide resolved
doc/architecture/database_schemata.md Outdated Show resolved Hide resolved
doc/architecture/database_schemata.md Outdated Show resolved Hide resolved
doc/architecture/database_schemata.md Outdated Show resolved Hide resolved
@markus2330
Copy link
Contributor

For first version we will enter everything only in German.

Copy link
Contributor

@markus2330 markus2330 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further comments.

db/create.sql Outdated Show resolved Hide resolved
doc/architecture/database_schemata.md Show resolved Hide resolved
doc/architecture/database_schemata.md Outdated Show resolved Hide resolved

```sql
CREATE TYPE tag AS ENUM (
'Leaf crops',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there are only a few occurrences in these enums, it probably should be translated like other UI text.

Translating the whole database will be the more interesting challenge.

doc/architecture/database_schemata.md Outdated Show resolved Hide resolved
db/create.sql Outdated Show resolved Hide resolved
db/create.sql Outdated Show resolved Hide resolved
db/create.sql Outdated Show resolved Hide resolved
db/create.sql Outdated Show resolved Hide resolved
db/create.sql Outdated Show resolved Hide resolved
@markus2330 markus2330 mentioned this pull request Jan 15, 2023
8 tasks
@markus2330 markus2330 merged commit e96a08f into master Jan 17, 2023
@markus2330 markus2330 deleted the architecture/db-schemata branch January 17, 2023 18:20
@markus2330
Copy link
Contributor

Great job!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants