-
Notifications
You must be signed in to change notification settings - Fork 13
Conversation
whoops, seems like there is a problem on GitHub rendering the er diagram, I'll take a look at it. edit: should be good now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
|
||
```sql | ||
CREATE TYPE tag AS ENUM ( | ||
'Leaf crops', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How will the translation work? Probably put the translation as a comment for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, good point. This could be done in many ways, for example in the service layer translating to German after querying the db or directly in the db. I'll comment it for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As there are only a few occurrences in these enums, it probably should be translated like other UI text.
Translating the whole database will be the more interesting challenge.
For first version we will enter everything only in German. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Further comments.
|
||
```sql | ||
CREATE TYPE tag AS ENUM ( | ||
'Leaf crops', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As there are only a few occurrences in these enums, it probably should be translated like other UI text.
Translating the whole database will be the more interesting challenge.
Great job! |
naming and data types can still be improved for sure