Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Replace openwrt image #4959

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Conversation

eiskasten
Copy link
Contributor

This PR tries to fix #4958 by replacing the openwrtorg/sdk with the openwrt/sdk docker image.

Basics

  • Short descriptions of your changes are in the release notes
    (added as entry in doc/news/_preparation_next_release.md which contains _(my name)_)
    Please always add them to the release notes.
  • Details of what you changed are in commit messages
    (first line should have module: short statement syntax)
  • References to issues, e.g. close #X, are in the commit messages.
  • The buildservers are happy. If not, fix in this order:
    • add a line in doc/news/_preparation_next_release.md
    • reformat the code with scripts/dev/reformat-all
    • make all unit tests pass
    • fix all memleaks
    • fix the CI itself (or rebase if already fixed)
  • The PR is rebased with current master.

Checklist

  • I added unit tests for my code
  • I fully described what my PR does in the documentation
    (not in the PR description)
  • I fixed all affected documentation (see Documentation Guidelines)
  • I fixed all affected decisions (see Decision Process)
  • I added code comments, logging, and assertions as appropriate (see Coding Guidelines)
  • I updated all meta data (e.g. README.md of plugins and METADATA.ini)
  • I mentioned every code not directly written by me in reuse syntax

Review

Labels

  • Add the "work in progress" label if you do not want the PR to be reviewed yet.
  • Add the "ready to merge" label if everything is done and no further pushes are planned by you.

Copy link
Contributor

@markus2330 markus2330 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this works, it would be perfect! 🚀

@eiskasten eiskasten changed the title Replace openwrt iamge Replace openwrt image Jun 7, 2023
@eiskasten
Copy link
Contributor Author

jenkins build libelektra please

1 similar comment
@eiskasten
Copy link
Contributor Author

jenkins build libelektra please

@eiskasten
Copy link
Contributor Author

The jenkins pipeline ran through now, it is currently quite unstable and often fails due to java related tasks. However, the cirrus tasks which involve the scripts/docker/cirrus/arch/Dockerfile always fail. Cirrus reports: Container errored with 'ImagePullBackOff: Back-off pulling image "gcr.io/cirrus-ci-community/elektrainitiative/libelektra/scripts/docker/cirrus/arch/dockerfile:192f328646916150a6104131ce20859c"'. The base image of the dockerfile, archlinux:base-devel is available to my local docker instance.

@markus2330 markus2330 merged commit cf77b9d into ElektraInitiative:master Jun 8, 2023
@4ydan 4ydan mentioned this pull request Jul 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to build docker images
2 participants