This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 123
Plugins: Improve c plugin (doc, tests, refactor) #4979
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- some small refactoring (e.g. remove unnecessary dups, reduce scope of variables) - add code documentation (Doxygen) - extended README.md - add unit tests
flo91
added
lang/c
lang/markdown
documentation
needs review
please review this PR
labels
Jul 12, 2023
In what state is this? Do you think this should also be part of the v0.11 release? |
This PR is basically finished and ready for reviews. |
markus2330
approved these changes
Jul 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, yes, let us take this in. Shell recorder tests would have been nice.
Comment on lines
+23
to
+24
So one use case is to extract a part of the KDB and copy the generated code | ||
to create the exported part of the KDB programmatically, e.g. for another Elektra installation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one line per sentence according to documentation guidelines.
Co-authored-by: Markus Raab <[email protected]>
Great work! |
jenkins build libelektra please |
2 similar comments
jenkins build libelektra please |
jenkins build libelektra please |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basics
(added as entry in
doc/news/_preparation_next_release.md
which contains_(my name)_
)Please always add them to the release notes.
(first line should have
module: short statement
syntax)close #X
, are in the commit messages.doc/news/_preparation_next_release.md
scripts/dev/reformat-all
Checklist
(not in the PR description)
Review
Labels