[0.17] Chainparams: Introduce consensus.genesis_style for compatibility #436
Conversation
jtimon
force-pushed
the
e17-genesis-style
branch
from
d3b93ad
to
5c90b43
Compare
jtimon
changed the title
jtimon
force-pushed
the
e17-genesis-style
branch
from
5c90b43
to
abca2d2
Compare
jtimon
changed the title
jtimon
force-pushed
the
e17-genesis-style
branch
from
abca2d2
to
0fcd8af
Compare
jtimon
changed the title
jtimon
force-pushed
the
e17-genesis-style
branch
2 times, most recently
from
01fd213
to
e195010
Compare
jtimon
force-pushed
the
e17-genesis-style
branch
2 times, most recently
from
c7f7b90
to
e75f8a0
Compare
jtimon
force-pushed
the
e17-genesis-style
branch
from
e75f8a0
to
806b355
Compare
|
Why not just provide the raw coinbase instead of a predefined "style", and default it to whatever commitments you want? |
|
Well, ideally the styles would unify with time (at least some of them, for example, liquidV1 has its own style not included here) and this seemed simpler. Feel free to create a competing PR. By the way, since liquid is now public, liquidv1's style could be implemented and tested here. Or perhaps I can do that on a separated PR on top of this one. |
|
@luke-jr raw coinbase such as what exactly? Just trying to understand the suggestion |
|
just noting we can add this test post-merge: f00e979#diff-912bf7afc60ccdf9de453ce3a8e0ffceR29 here |
|
Closing for now, we're supporting this piecemeal. |
|
I don't follow. What piece of meal?
Why is it closed?
…On Tue, Dec 18, 2018, 22:10 Gregory Sanders ***@***.*** wrote:
Closed #436 <#436>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#436 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA9jSnfiLlFe74wBtGiTHkTid3wH2qxZks5u6VnigaJpZM4XjDge>
.
|
|
I meant that Carl has taken half of this PR(note #467) and introduced two genesis styles already. |
Introduces consensus.genesis_style for compatibility and sanity tests.
Style "default_style" is what is meant to be used and extended, since it opens the door to commit to any chainparams we would like to commit.
Style "regtest2_style" is for compatibility with bitcoin/bitcoin#8994
I'm trying to make sure that #433 can be compatible with kallewoof/bitcoin#5 using "signet_old" in #433, but I'm not getting the genesis block hash that I expect, this is driving me kind of crazy, see kallewoof/bitcoin#6 for additional context.
In the PR for block signing I plan to create another style for elements-0.14 compatibility.