Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request: don't log fee-related messages in regtest mode #1806

Closed
shesek opened this issue Aug 6, 2018 · 4 comments
Closed

Request: don't log fee-related messages in regtest mode #1806

shesek opened this issue Aug 6, 2018 · 4 comments
Labels
enhancement logging

Comments

@shesek
Copy link
Contributor

shesek commented Aug 6, 2018

They fill up the logs and make it hard to find anything else, and regtest doesn't have fee estimation anyway.
@SimonVrouwe
Copy link
Collaborator

How about only logging fee-rates when they change?

@SimonVrouwe SimonVrouwe mentioned this issue Aug 11, 2018
Merged
@SimonVrouwe
Copy link
Collaborator

@shesek #1825 disables fee estimation and corresponding log messages, when you use the option (for example) --dev-override-fee-rates 40000/20000/10000

@s-tikhomirov s-tikhomirov mentioned this issue Jan 9, 2020
Open
@NicolasDorier
Copy link
Collaborator

Should be reopened. --dev-override-fee-rates has been removed, reopening this issue.

@ZmnSCPxj
Copy link
Collaborator

Reopening as per @NicolasDorier

@ZmnSCPxj ZmnSCPxj reopened this Jan 13, 2020
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Jul 3, 2021
@rustyrussell
lightningd: add force-feerates option.
937dcc5 
Useful for regtest and testnet.  Sure, you shouldn't use this on mainnet,
but I haven't restricted it because our users are usually pretty clever.

Signed-off-by: Rusty Russell <[email protected]>
Fixes: ElementsProject#1806
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Jul 3, 2021
@rustyrussell
lightningd: add force-feerates option.
6239684 
Useful for regtest and testnet.  Sure, you shouldn't use this on mainnet,
but I haven't restricted it because our users are usually pretty clever.

Signed-off-by: Rusty Russell <[email protected]>
Fixes: ElementsProject#1806
Changelog-Added: config: `force_feerates` option to allow overriding feerate estimates (mainly for regtest).
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Jul 8, 2021
@rustyrussell
lightningd: add force-feerates option.
368b265 
Useful for regtest and testnet.  Sure, you shouldn't use this on mainnet,
but I haven't restricted it because our users are usually pretty clever.

Signed-off-by: Rusty Russell <[email protected]>
Fixes: ElementsProject#1806
Changelog-Added: config: `force_feerates` option to allow overriding feerate estimates (mainly for regtest).
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Jul 8, 2021
@rustyrussell
lightningd: add force-feerates option.
5e3577e 
Useful for regtest and testnet.  Sure, you shouldn't use this on mainnet,
but I haven't restricted it because our users are usually pretty clever.

Signed-off-by: Rusty Russell <[email protected]>
Fixes: ElementsProject#1806
Changelog-Added: config: `force_feerates` option to allow overriding feerate estimates (mainly for regtest).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement logging
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@cdecker @shesek @NicolasDorier @SimonVrouwe @ZmnSCPxj