Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should accept lower fees for a grace period after raising them #4761

Closed
rustyrussell opened this issue Sep 3, 2021 · 0 comments
Closed

Should accept lower fees for a grace period after raising them #4761

rustyrussell opened this issue Sep 3, 2021 · 0 comments
Assignees
@rustyrussell
Milestone
v0.10.2

Comments

@rustyrussell
Copy link
Contributor

Increasing channel fees takes place immediately, but the changes take a while to propagate. This means rejecting payments for a while.

(If we reduce fees, we already accept overpayment, so that case is covered).

We should add a parameter to setchannelfee which is a grace period, default 10 minutes (does anyone have an idea of propagation times?)
@rustyrussell rustyrussell added this to the v0.10.2 milestone Sep 3, 2021
@rustyrussell rustyrussell self-assigned this Sep 3, 2021
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Sep 22, 2021
@rustyrussell
lightningd: provide 10 minutes for channel fee increases to propagate.
08fbe1e 
This was measured as a 95th percentile in our rough testing, thanks to
all the volunteers who monitored my channels.

Fixes: ElementsProject#4761
Signed-off-by: Rusty Russell <[email protected]>
Changelog-Added: JSON-RPC: `setchannelfee` gives a grace period (`enforcedelay`) before rejecting old-fee payments: default 10 minutes.
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Sep 22, 2021
@rustyrussell
lightningd: provide 10 minutes for channel fee increases to propagate.
3079c42 
This was measured as a 95th percentile in our rough testing, thanks to
all the volunteers who monitored my channels.

Fixes: ElementsProject#4761
Signed-off-by: Rusty Russell <[email protected]>
Changelog-Added: JSON-RPC: `setchannelfee` gives a grace period (`enforcedelay`) before rejecting old-fee payments: default 10 minutes.
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Sep 22, 2021
@rustyrussell
lightningd: provide 10 minutes for channel fee increases to propagate.
7871e8b 
This was measured as a 95th percentile in our rough testing, thanks to
all the volunteers who monitored my channels.

Fixes: ElementsProject#4761
Signed-off-by: Rusty Russell <[email protected]>
Changelog-Added: JSON-RPC: `setchannelfee` gives a grace period (`enforcedelay`) before rejecting old-fee payments: default 10 minutes.
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Sep 23, 2021
@rustyrussell
lightningd: provide 10 minutes for channel fee increases to propagate.
25acf5a 
This was measured as a 95th percentile in our rough testing, thanks to
all the volunteers who monitored my channels.

Fixes: ElementsProject#4761
Signed-off-by: Rusty Russell <[email protected]>
Changelog-Added: JSON-RPC: `setchannelfee` gives a grace period (`enforcedelay`) before rejecting old-fee payments: default 10 minutes.
@remyers remyers mentioned this issue Mar 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustyrussell rustyrussell

Labels
None yet
Projects
None yet
Milestone
v0.10.2
Development

No branches or pull requests
1 participant
@rustyrussell