-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to build 22.11 on arm32 #5776
Milestone
Comments
Good catch! Will fix... |
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this issue
Dec 5, 2022
It's obviously the incorrect type, while our CI didn't catch it, Nicholas did: ``` plugins/fetchinvoice.c:1362:30: error: conversion from 'long long unsigned int' to 'size_t' {aka 'unsigned int'} changes value from '18446744073709551615' to '4294967295' [-Werror=overflow] 1362 | || tlv_span(wire, 1001, UINT64_MAX, NULL) != 0) { ``` Reported-by: @NicholasDorier Signed-off-by: Rusty Russell <[email protected]> Changelog-Fixed: Build: arm32 compiler error in fetchinvoice, due to bad types on 32-bit platforms. Fixes: ElementsProject#5776
cdecker
pushed a commit
that referenced
this issue
Dec 6, 2022
It's obviously the incorrect type, while our CI didn't catch it, Nicholas did: ``` plugins/fetchinvoice.c:1362:30: error: conversion from 'long long unsigned int' to 'size_t' {aka 'unsigned int'} changes value from '18446744073709551615' to '4294967295' [-Werror=overflow] 1362 | || tlv_span(wire, 1001, UINT64_MAX, NULL) != 0) { ``` Reported-by: @NicholasDorier Signed-off-by: Rusty Russell <[email protected]> Changelog-Fixed: Build: arm32 compiler error in fetchinvoice, due to bad types on 32-bit platforms. Fixes: #5776
ddustin
pushed a commit
to ddustin/lightning
that referenced
this issue
Apr 11, 2023
It's obviously the incorrect type, while our CI didn't catch it, Nicholas did: ``` plugins/fetchinvoice.c:1362:30: error: conversion from 'long long unsigned int' to 'size_t' {aka 'unsigned int'} changes value from '18446744073709551615' to '4294967295' [-Werror=overflow] 1362 | || tlv_span(wire, 1001, UINT64_MAX, NULL) != 0) { ``` Reported-by: @NicholasDorier Signed-off-by: Rusty Russell <[email protected]> Changelog-Fixed: Build: arm32 compiler error in fetchinvoice, due to bad types on 32-bit platforms. Fixes: ElementsProject#5776
ddustin
pushed a commit
to ddustin/lightning
that referenced
this issue
May 12, 2023
It's obviously the incorrect type, while our CI didn't catch it, Nicholas did: ``` plugins/fetchinvoice.c:1362:30: error: conversion from 'long long unsigned int' to 'size_t' {aka 'unsigned int'} changes value from '18446744073709551615' to '4294967295' [-Werror=overflow] 1362 | || tlv_span(wire, 1001, UINT64_MAX, NULL) != 0) { ``` Reported-by: @NicholasDorier Signed-off-by: Rusty Russell <[email protected]> Changelog-Fixed: Build: arm32 compiler error in fetchinvoice, due to bad types on 32-bit platforms. Fixes: ElementsProject#5776
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: