gossipd: fixes for experimental crcs and query flags #2999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently EXPERIMENTAL_FEATURES only, fortunately. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
fix-crc32-of-update
branch
from
86e8e06
to
f8d03b3
Compare
rustyrussell
force-pushed
the
fix-crc32-of-update
branch
from
f8d03b3
to
defa89b
Compare
Signed-off-by: Rusty Russell <[email protected]>
Fortunately, again, only happens with EXPERIMENTAL_FEATURES. If the query causes us not to actually send anything, we won't get called again. This can validly happen if they only asked for the node_announcements, for example. (Found by protocol tests). Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
fix-crc32-of-update
branch
from
defa89b
to
b5d0c09
Compare
rustyrussell
changed the title
|
ACK b5d0c09 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently EXPERIMENTAL_FEATURES only, fortunately.
See: lightning/bolts#557