Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyln: Migrate testing utilities and fixtures into pyln-testing #3218

Merged
merged 9 commits into from
Nov 12, 2019
Merged

pyln: Migrate testing utilities and fixtures into pyln-testing #3218

merged 9 commits into from
Nov 12, 2019

Commits on Nov 11, 2019

  1. pyln: Migrate implementation from pylightning to pyln-client 

    This should not affect any consumer of the API since we just shift the actual
implementation from one side to the other, and keep aliases in place so
scripts don't break.

We also bump the version number from 0.0.7.3 to 0.7.4 which allows us to be in
sync with c-lightning itself, and remove the superfluous `0` in front.
    @cdecker
    cdecker committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    66f21ca View commit details
    Browse the repository at this point in the history

  2. pyln-testing: Copy basic support infrastructure into pyln.testing 

    We'll rewrite the tests to use this infrastructure in the next commit.

Changelog-Added: The new `pyln-testing` package now contains the testing infrastructure so it can be reused to test against c-lighting in external projects
    @cdecker
    cdecker committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    7203a6c View commit details
    Browse the repository at this point in the history

  3. pytest: Consolidate access to environment variables 

    We use `env()` to look up configuration variables and allow them to be
overridden by the environment.
    @cdecker
    cdecker committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    6f9de27 View commit details
    Browse the repository at this point in the history

  4. make: Add in-tree pyln-testing to python path 

    We'll start relying on the in-tree version pretty soon, so we better make
sure we find it.
    @cdecker
    cdecker committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    b3f6b1d View commit details
    Browse the repository at this point in the history

  5. pytest: Migrate env to pyln-testing

    @cdecker
    cdecker committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    ecb74be View commit details
    Browse the repository at this point in the history

  6. pytest: Migrate to in-tree pyln-testing

    @cdecker
    cdecker committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    e0deaa6 View commit details
    Browse the repository at this point in the history

  7. pyln: Default to DEVELOPER=0 when running outside of tree 

    `DEVELOPER=1` assumes that the binary has been compiled with developer set to
true, which might not be the case for plugin developers. Setting this to 0 by
default has no effect in c-lightning since we always at least set it in
`config.vars` but may prevent some issues outside.
    @cdecker
    cdecker committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    6fc4eee View commit details
    Browse the repository at this point in the history

  8. pyln: Move RPC and daemon instantiation into the LightningNode 

    We were relying heavily on NodeFactory to do some magic before instantiating
the Node with rpc and daemon initialized, that meant that we'd have to replace
all 3 classes when customizing the node to our needs. Moving that
initialization into the node itself means that the LightningNode class now can
be swapped out and customized, without having to wire everything else through.
    @cdecker
    cdecker committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    6fea4e5 View commit details
    Browse the repository at this point in the history

  9. pyln: Allow users to override the LightningNode class 

    Quite a few of the things in the LightningNode class are tailored to their use
in the c-lightning tests, so I decided to split those customizations out into
a sub-class, and adding one more fixture that just serves the class. This
allows us to override the LightningNode implementation in our own tests, while
still having sane defaults for other users.
    @cdecker
    cdecker committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    169019e View commit details
    Browse the repository at this point in the history