Handle reply_channel_range from LND (and enhance gossipwith) #3264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
changed the title
cdecker
reviewed
Nov 17, 2019
| if (first_blocknum == peer->range_first_blocknum | ||
| && first_blocknum + number_of_blocks == peer->range_end_blocknum | ||
| && !complete | ||
| && tal_bytelen(msg) == 64046) { |
There was a problem hiding this comment.
Where does this constant come from?
There was a problem hiding this comment.
That's the size of the message LND sends (8000 uncompressed scids). I wanted this workaround to be as narrow as possible to avoid catching real cases.
I always get this wrong, then wonder why it's dying! Signed-off-by: Rusty Russell <[email protected]>
Signed-off-by: Rusty Russell <[email protected]>
Particularly important when talking with modern lnd, which will hang up on you if you don't offer feature bit 1! Signed-off-by: Rusty Russell <[email protected]>
We've been sending them errors for invalid replies; instead, this works around it. Changelog-Added: Workaround LND's reply_channel_range issues instead of sending error. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
gossipwith-tuneup
branch
from
bbcc632
to
ced01b3
Compare
|
ACK ced01b3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See lightningnetwork/lnd#3728
Tested and verified on my node, under valgrind.