Minor driveby cleanups #3409
Merged
Minor driveby cleanups #3409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valgrind doesn't really like crashes if compiled without DEVELOPER since that seems to compile out the debug symbols, resulting in the following error: ``` Optimistic lock on the database failed. There may be a concurrent access to the database. Aborting since concurrent access is unsafe. lightningd: FATAL SIGNAL 6 (version 0.0.99) lightningd/lightningd: libbacktrace: no debug info in ELF executable lightningd/lightningd: libbacktrace: no debug info in ELF executable lightningd/lightningd: libbacktrace: no debug info in ELF executable lightningd/lightningd: libbacktrace: no debug info in ELF executable lightningd/lightningd: libbacktrace: no debug info in ELF executable lightningd/lightningd: libbacktrace: no debug info in ELF executable lightningd/lightningd: libbacktrace: no debug info in ELF executable lightningd/lightningd: libbacktrace: no debug info in ELF executable lightningd/lightningd: libbacktrace: no debug info in ELF executable lightningd/lightningd: libbacktrace: no debug info in ELF executable lightningd/lightningd: libbacktrace: no debug info in ELF executable lightningd/lightningd: libbacktrace: no debug info in ELF executable lightningd/lightningd: libbacktrace: no debug info in ELF executable lightningd: FATAL SIGNAL 11 (version 0.0.99) lightningd/lightningd: libbacktrace: no debug info in ELF executable lightningd/lightningd: libbacktrace: no debug info in ELF executable lightningd/lightningd: libbacktrace: no debug info in ELF executable lightningd/lightningd: libbacktrace: no debug info in ELF executable 2020-01-07 15:26:03.539 EST [11583] LOG: unexpected EOF on client connection with an open transaction --------------------------- Captured stdout teardown --------------------------- DEBUG:root:Calling stop with payload None ------------------------------- Valgrind errors -------------------------------- Valgrind error file: valgrind-errors.11409 ==11409== Jump to the invalid address stated on the next line ==11409== at 0x0: ??? ==11409== by 0x1C00A8: backtrace_full (backtrace.c:127) ==11409== by 0x147B0A: send_backtrace (daemon.c:46) ==11409== by 0x147B55: crashdump (daemon.c:54) ==11409== by 0x6071F1F: ??? (in /lib/x86_64-linux-gnu/libc-2.27.so) ==11409== by 0x6071E96: __libc_signal_restore_set (nptl-signals.h:80) ==11409== by 0x6071E96: raise (raise.c:48) ==11409== by 0x6073800: abort (abort.c:79) ==11409== by 0x12B2FF: fatal (log.c:819) ==11409== by 0x16FA3B: db_data_version_incr (db.c:826) ==11409== by 0x16FA9E: db_commit_transaction (db.c:841) ==11409== by 0x124D20: io_loop_with_timers (io_loop_with_timers.c:34) ==11409== by 0x129260: main (lightningd.c:860) ==11409== Address 0x0 is not stack'd, malloc'd or (recently) free'd ==11409== ==11409== ==11409== Process terminating with default action of signal 11 (SIGSEGV) ==11409== Bad permissions for mapped region at address 0x0 ==11409== at 0x0: ??? ==11409== by 0x1C00A8: backtrace_full (backtrace.c:127) ==11409== by 0x147B0A: send_backtrace (daemon.c:46) ==11409== by 0x147B55: crashdump (daemon.c:54) ==11409== by 0x6071F1F: ??? (in /lib/x86_64-linux-gnu/libc-2.27.so) -------------------------------------------------------------------------------- ```
How did these ever work?
TIL: `rename` doesn't like its source and target to be on different partitions. This was causing the `hsmtool` tests to fail whenever we ran them on a different partition than the lightning-dir (e.g., `/dev/shm` for faster testing), because we made the backup copy in the current working directory. This changes this and creates the backup next to the original file, which has a reasonable chance to be on the same partition. Changelog-Changed: hsmtool: The `hsmtool` now creates its backup copy in the same directory as the original `hsm_secret` file.
darosior
approved these changes
Jan 10, 2020
|
tor test localy 👍 with open tor browser app ver. 9.0.4 that will open on default port 9150 and 9151 tACK 3eb17bf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing some pytest tests that were failing on my local machine or the CI I'm working on.
DEVELOPER=0+VALGRIND=1+ an expected node failure don't combine that well, since the backtrace can't find debug symbolshsmtoolwas assuming the$cwdis on the same partition as the lightning-dir.