Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass typed plugin option data to plugin in init #3582

Merged
merged 7 commits into from
Mar 10, 2020
Merged

Pass typed plugin option data to plugin in init #3582

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c2a53b1
pyln-testing: save stderr logs for checking
niftynei Mar 8, 2020
ba49d03
pyln-testing: add flag 'expect_fail' to node factory get_node
niftynei Mar 8, 2020
a8e9324
plugins: pass back opts as indicated type. fixes #3577
niftynei Mar 8, 2020
a413dc5
pyln: enforce types of options
niftynei Mar 8, 2020
b1b8fcb
plugins: use stricter parsing for option values
niftynei Mar 8, 2020
dc70867
plugins: test for option value checking and parsing
niftynei Mar 8, 2020
e9239d9
plugin: add in deprecated_api behavior and test
niftynei Mar 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions contrib/pyln-client/pyln/client/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,9 @@ def add_option(self, name, default, description, opt_type="string"):
"Name {} is already used by another option".format(name)
)

if opt_type not in ["string", "int", "bool"]:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[commit msg]

not sure if this is totally necessary, should we jsut let clightning
enforce the input?

Might be a bit redundant but an advantage is that one can see its mistake just by trying its plugin with python3 myplugin.py..

raise ValueError('{} not in supported type set (string, int, bool)')

self.options[name] = {
'name': name,
'default': default,
Expand Down