Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiwithdraw #3812

Merged
merged 4 commits into from
Sep 9, 2020
Merged

Multiwithdraw #3812

merged 4 commits into from
Sep 9, 2020

Conversation

ZmnSCPxj
Copy link
Collaborator

@ZmnSCPxj ZmnSCPxj commented Jul 4, 2020

Fixes: #2679

@ZmnSCPxj
Copy link
Collaborator Author

Reimplemented as a plugin.

Not sure how this relates to #3867..

@ZmnSCPxj ZmnSCPxj force-pushed the multiwithdraw branch 2 times, most recently from a1425ca to dbf0e2f Compare August 21, 2020 09:05
@ZmnSCPxj
Copy link
Collaborator Author

Rebased, also added missing dust limit checks.

Copy link
Contributor

@rustyrussell rustyrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack c920925

"multiwithdraw",
"bitcoin",
"Send to multiple {outputs} via a single Bitcoin transaction.",
"Send to multiple {outputs} at optiona {feerate}, spending "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: optional

p_req("outputs", param_outputs_array, &mw->outputs),
p_opt("feerate", param_string, &mw->feerate),
p_opt_def("minconf", param_number, &mw->minconf, 1),
p_opt("utxos", param_string, &mw->utxos),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

param_string is ugly here, BTW. We should have a param_utxos?

@rustyrussell
Copy link
Contributor

Trivial rebase on top of #3973 (which is about to be merged, once Travis is happy)

Fixes: ElementsProject#2679

Changelog-Added: JSON-RPC: New `multiwithdraw` command to batch multiple onchain sends in a single transaction.  Note it shuffles inputs and outputs, does not use BIP69.
@rustyrussell
Copy link
Contributor

Ack 5a6222c

@rustyrussell rustyrussell merged commit c618682 into ElementsProject:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: withdraw to multiple addresses
2 participants