Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UTXO selection cleanups and preps #3821

Merged
merged 6 commits into from
Jul 8, 2020
Merged

UTXO selection cleanups and preps #3821

merged 6 commits into from
Jul 8, 2020

Commits on Jul 7, 2020

  1. bitcoin/feerate: new exposure for feerate parsing outside lightningd. 

    This exposes the numeric part of param_feerate() as param_feerate_val().

Signed-off-by: Rusty Russell <[email protected]>
    @rustyrussell
    rustyrussell committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    e66096b View commit details
    Browse the repository at this point in the history

  2. param_feerate: parse numbers correctly. 

    If you used feerate=750, instead of feerate="750" it didn't work, since the
token is not a string.

Signed-off-by: Rusty Russell <[email protected]>
Changelog-Fixed: JSON RPC: `withdraw` and `txprepare` `feerate` can be a JSON number.
    @rustyrussell
    rustyrussell committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    0041eef View commit details
    Browse the repository at this point in the history

  3. listfunds: add scriptpubkey if it's known. 

    (Which it is, since 0.7.3).

Signed-off-by: Rusty Russell <[email protected]>
Changelog-Added: JSON: `listfunds` now has a 'scriptpubkey' field.
    @rustyrussell
    rustyrussell committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    e8423c4 View commit details
    Browse the repository at this point in the history

  4. common/json_tok: expose routines to parse addresses. 

    These are currently inside lightningd.

Signed-off-by: Rusty Russell <[email protected]>
    @rustyrussell
    rustyrussell committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    946b579 View commit details
    Browse the repository at this point in the history

  5. change_amount: routine to determine if change output is worthwhile. 

    This can be used by plugins which create their own txs.

Signed-off-by: Rusty Russell <[email protected]>
    @rustyrussell
    rustyrussell committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    8314471 View commit details
    Browse the repository at this point in the history

  6. common/json_tok: expose param_txid. 

    Move it out of lightningd/ so plugins can use it.

Signed-off-by: Rusty Russell <[email protected]>
    @rustyrussell
    rustyrussell committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    93e273f View commit details
    Browse the repository at this point in the history