Plugins can deprecate too!

[rustyrussell]

I wrote all this then realized that the cmd I wanted to patch wasn't in a plugin at all!

Oh well!

[darosior]

Nice, this plays well with the legacy "nothing's deprecated"

[rustyrussell]

Trivial rebase, with @ZmnSCPxj 's wording improvement (which incorporated @niftynei typo fix as a side-effect).

[ZmnSCPxj]

Looks fine, but some style/grammar nits.

[rustyrussell]

Minor fixes, here's the diff:

diff --git a/doc/PLUGINS.md b/doc/PLUGINS.md
index 6b3fdc617..e03b13894 100644
--- a/doc/PLUGINS.md
+++ b/doc/PLUGINS.md
@@ -60,8 +60,8 @@ interface.
 The `getmanifest` method is required for all plugins and will be
 called on startup with optional parameters (in particular, it may have
 `allow-deprecated-apis: false`, but you should accept, and ignore,
-other parameters your plugin does not expect others).  It MUST return
-a JSON object similar to this example:
+other parameters).  It MUST return a JSON object similar to this
+example:
 
 ```json
 {
diff --git a/lightningd/jsonrpc.c b/lightningd/jsonrpc.c
index 50c47e0ad..cdb75aea8 100644
--- a/lightningd/jsonrpc.c
+++ b/lightningd/jsonrpc.c
@@ -390,13 +390,13 @@ static struct command_result *json_help(struct command *cmd,
 		if (!one_cmd)
 			return command_fail(cmd, JSONRPC2_METHOD_NOT_FOUND,
 					    "Unknown command '%.*s'",
-					    cmdtok->end - cmdtok->start,
-					    buffer + cmdtok->start);
+					    json_tok_full_len(cmdtok),
+					    json_tok_full(buffer, cmdtok));
 		if (!deprecated_apis && one_cmd->deprecated)
 			return command_fail(cmd, JSONRPC2_METHOD_NOT_FOUND,
 					    "Deprecated command '%.*s'",
-					    cmdtok->end - cmdtok->start,
-					    buffer + cmdtok->start);
+					    json_tok_full_len(cmdtok),
+					    json_tok_full(buffer, cmdtok));
 	} else
 		one_cmd = NULL;
 
@@ -850,8 +850,8 @@ parse_request(struct json_connection *jcon, const jsmntok_t tok[])
 	if (c->json_cmd->deprecated && !deprecated_apis) {
 		return command_fail(c, JSONRPC2_METHOD_NOT_FOUND,
 				    "Command '%.*s' is deprecated",
-				    method->end - method->start,
-				    jcon->buffer + method->start);
+				    json_tok_full_len(method),
+				    json_tok_full(jcon->buffer, method));
 	}
 
 	rpc_hook = tal(c, struct rpc_command_hook_payload);
diff --git a/plugins/libplugin.c b/plugins/libplugin.c
index 2d4e009a0..d0cb66607 100644
--- a/plugins/libplugin.c
+++ b/plugins/libplugin.c
@@ -580,8 +580,12 @@ handle_getmanifest(struct command *getmanifest_cmd,
 	dep = json_get_member(buf, getmanifest_params, "allow-deprecated-apis");
 	if (!dep)
 		deprecated_apis = true;
-	else
-		json_to_bool(buf, dep, &deprecated_apis);
+	else {
+		if (!json_to_bool(buf, dep, &deprecated_apis))
+			plugin_err(p, "Invalid allow-deprecated-apis '%.*s'",
+				   json_tok_full_len(dep),
+				   json_tok_full(buf, dep));
+	}
 
 	json_array_start(params, "options");
 	for (size_t i = 0; i < tal_count(p->opts); i++) {

[rustyrussell]

Trivial rebase (quote changed broke string match in tests)...

[rustyrussell]

Ack bd61cd5