Dev flag to set features #3976
Merged
Dev flag to set features #3976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZmnSCPxj
reviewed
Aug 25, 2020
| """Smoke test for a channel without option_static_remotekey""" | ||
| l1, l2 = node_factory.line_graph(2, | ||
| opts=[{}, | ||
| {'dev-force-features': '////'}]) |
There was a problem hiding this comment.
Description says "comma", why does this use "/"?
| if (tal_count(parts) != NUM_FEATURE_PLACE) | ||
| return "Expected 5 feature sets (init, globalinit, node_announce, channel, bolt11) separated by /"; | ||
| for (size_t i = 0; parts[i]; i++) { | ||
| char **bits = tal_strsplit(tmpctx, parts[i], ",", STR_EMPTY_OK); |
There was a problem hiding this comment.
error above says "/", why does this split by ","?
There was a problem hiding this comment.
5 sets, separated by /, each a set of 0 or more feature bitnumbers separated by ,.
I didn't document thoroughly since it's a dev-only option...
niftynei
approved these changes
Sep 1, 2020
And use it to smoke-test !option_static_remotekey. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
dev-set-features
branch
from
98e05b5
to
9bc5c1b
Compare
|
Trivial rebase after #3963 merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Based on #3963]
This means we at least check that non-static-remotekey peers are not completely broken!
Changelog-None