gossipd: Make gossipd shut up #3981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It wasn't waiting for the tx to be in the mempool
We are logging way too much from gossipd, causing noisy logs. This PR reduces logs for incoming messages to those that actually caused a change in our internal state (duplicate and old messages are just dropped silently now). Changelog-Changed: gossipd: The `gossipd` is now a lot quieter, and will log only when a message changed our network topology.
rustyrussell
approved these changes
Aug 27, 2020
There was a problem hiding this comment.
Ack 7c2a9f1
For reference, in my logfile of 6.1M lines:
- Ignoring redundant update: 2M lines
- Ignoring redundant nannounce: 96k lines
- Received channel_update: 2.9M lines
- Ignoring update timestamp: 40k lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are logging way too much from gossipd, causing noisy logs. This PR reduces
logs for incoming messages to those that actually caused a change in our
internal state (duplicate and old messages are just dropped silently now).
Most of the changes are related to tests breaking due to the reduced logging,
and the fixups required to get them working again. We fix them by polling for
the desired resulting state rather than observing the ephemeral state changes
represented by the logs. This may slow down some of the tests, since we now
poll, but that time is likely going to be used by concurrent tests anyway, and
we end up with more stable tests, that don't rely on implicit log ordering..
Changelog-Changed: gossipd: The
gossipdis now a lot quieter, and will log only when a message changed our network topology.