Reduce build requirements for non-developers, neaten build system #3994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
guilt/non-devs-reduce-requirements
branch
13 times, most recently
from
889fa33
to
3c84f6a
Compare
This should be more robust in future: we SHA256 all of the deps. For wiregen we prefix with EXPERIMENTAL_FEATURES, since it can effect them. Signed-off-by: Rusty Russell <[email protected]>
Now we use the same Makefile rules for all CSV->C generation. Signed-off-by: Rusty Russell <[email protected]>
We're going to make check-source cover every C file soon. Signed-off-by: Rusty Russell <[email protected]>
We create ALL_PROGRAMS, ALL_TEST_PROGRAMS, ALL_C_SOURCES and ALL_C_HEADERS. Then the toplevel Makefile knows which are autogenerated (by wildcard), so it can have all the rules to clean them or check the source as necessary. Signed-off-by: Rusty Russell <[email protected]>
Now that SHA256STAMP protects us, we can avoid timestamps altogether so we don't get missing builds. Signed-off-by: Rusty Russell <[email protected]>
And rename them so they're not cleared by `make clean`. We leave the old rules in place so old files get cleaned still. Signed-off-by: Rusty Russell <[email protected]>
Signed-off-by: Rusty Russell <[email protected]> Changelog-Changed: Build: we no longer require extra Python modules to build.
``` make: *** No rule to make target 'external/gheap/gheap.h', needed by 'bitcoin/chainparams.o'. Stop. make: *** Waiting for unfinished jobs.... ``` Just simplify the Makefile to make all the external headers we use dependent on submodcheck. Signed-off-by: Rusty Russell <[email protected]>
Otherwise make thinks we're done, and we can get errors. Include primitive code if we abort build halfway and leave .refresh-submodules dir. Signed-off-by: Rusty Russell <[email protected]>
The $(TARGET_DIR) may not exist: use mkdir -p. Signed-off-by: Rusty Russell <[email protected]>
And guard the mako-specific tests with a check instead. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/non-devs-reduce-requirements
branch
2 times, most recently
from
5866ba7
to
3f38155
Compare
rustyrussell
force-pushed
the
guilt/non-devs-reduce-requirements
branch
3 times, most recently
from
4274209
to
f096d44
Compare
This tests our instructions in INSTALL.md, which say you only need requirements.txt for development or running tests, not building. Also removes the unused SOURCE_CHECK_ONLY flag. Signed-off-by: Rusty Russell <[email protected]>
It's far less verbose than it used to be! And it's occasionally useful. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/non-devs-reduce-requirements
branch
from
f096d44
to
6e8cbbc
Compare
niftynei
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to checkin all the files which we'd need sophisticated python (I'm looking at you, mako!) to build. That way our documentation, which says you only need to pip3 install stuff, is accurate.
I also did numerous parallel builds from fresh git checkouts, which found several issues.
The final commit switches Travis to not install any of that on the "not running unit tests" cases, which will detect cases I missed.