Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elements PSBT / test fixup #4033

Merged
merged 10 commits into from
Sep 10, 2020
Merged

Elements PSBT / test fixup #4033

merged 10 commits into from
Sep 10, 2020

Commits on Sep 10, 2020

  1. elementsd: use the elements version of a 'witness utxo' 

    Elements requires the witness utxo to include the asset and value info,
in order for the signing hash to be constructed correctly

Changelog-Fixed: elementsd: PSBTs include correct witness_utxo struct for elements transactions
    @niftynei
    niftynei committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    d5bf271 View commit details
    Browse the repository at this point in the history

  2. elements: include the value + asset tag for 'PSET's 

    Not strictly necessary as technically this info is included in the
witness_utxo, but nice to have
    @niftynei
    niftynei committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    f8b34af View commit details
    Browse the repository at this point in the history

  3. elements: run sign + send psbt check for elements tests 

    Now that we're using an 'elements' witness_utxo and issue 3998 has been
resolved, this should work as expected.
    @niftynei
    niftynei committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    f317c0a View commit details
    Browse the repository at this point in the history

  4. bitcoin: pull up elements_fee calc to allow wtx passed in 

    We're moving away from bitcoin_tx, slowly
    @niftynei
    niftynei committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    0da50ae View commit details
    Browse the repository at this point in the history

  5. txprepare: elements requires inclusion of an accurate fee output 

    so we add an accurate one
    @niftynei
    niftynei committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    34204c1 View commit details
    Browse the repository at this point in the history

  6. test_txprepare: skip over fee outputs (elements)

    @niftynei
    niftynei committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    5debfc7 View commit details
    Browse the repository at this point in the history

  7. test_utxopsbt: account for fee output diff when elements

    @niftynei
    niftynei committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    539bd12 View commit details
    Browse the repository at this point in the history

  8. elements: use normalization for elements fee output 

    This will update the fee output if it exists, rather than unilaterally
adding a new one.

Also, if the fee output already exists, we should make sure that it
doesn't interfere with the outnums of the other outputs
    @niftynei
    niftynei committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    ea1a192 View commit details
    Browse the repository at this point in the history

  9. elements: these can coin moves can arrive in either order

    @niftynei
    niftynei committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    b2826d8 View commit details
    Browse the repository at this point in the history

  10. elements: consolidate fee outputs into a single fee output 

    In the case that you've got more than one fee output already on a
psbt, we consolidate them into a single fee output (the first)
    @niftynei
    niftynei committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    6cf66e6 View commit details
    Browse the repository at this point in the history