chore: reduce log buffer from 100MB to 10MB #4087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 100MB log buffer has been the biggest memory footprint for the daemon. Keeping 10MB for emergency log dumps seems sufficient. This has been mentioned in the last developer meeting. Changelog-Changed: In-memory log buffer reduced from 100MB to 10MB
|
Except the log holds everything, esp debug logs and io logs (to subdaemons and all JSON RPC). My log is 970266 seconds old, and it has 28886 entries (ignoring the "skipped" entries), and has eliminated 1150070. This equates to 1.2 log entries per second. So I agree we should reduce this by 10, or even 100. |
|
Ack b8cff9d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 100MB log buffer has been the biggest memory footprint for the daemon.
Keeping 10MB for emergency log dumps seems sufficient.
This has been mentioned in the last developer meeting.
Update: As @rustyrussell points out the log buffer always contains everything regardless of the config (io, esp and debug, ...). An average log entry has about 170Bytes, lets say 200Bytes with certain overhead. A well connected node may produce something like up to ~2 events per second depending on usage. Thus a 10MB buffer will last for ~8Hrs.
Changelog-Changed: In-memory log buffer reduced from 100MB to 10MB