Expose close_to up through multifundchannel + fundchannel
#4132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
approved these changes
Oct 16, 2020
There was a problem hiding this comment.
Ack c256ce1
Some changes are in wrong commit though, needs rebase...
plugins/spender/multifundchannel.c
Outdated
| @@ -516,6 +524,8 @@ param_destinations_array(struct command *cmd, const char *name, | |||
| p_opt_def("announce", param_bool, &announce, true), | |||
| p_opt_def("push_msat", param_msat, &push_msat, | |||
| AMOUNT_MSAT(0)), | |||
| /* FIXME: do address validation here */ | |||
There was a problem hiding this comment.
Remove FIXME? Or turn into a note that opening will fail if it's not valid anyway...
There was a problem hiding this comment.
Left the fixme, added a note about validity and 'eventually failing'.
niftynei
force-pushed
the
nifty/fc-close-to
branch
from
c256ce1
to
41470af
Compare
This will allow us to let `fundchannel` handle a close to address, also
Finally, extends the 'close_to' functionality up to the flagship 'open a channel' command. Changelog-Added: JSON-API `fundchannel` now accepts an optional 'close_to' param, a bitcoin address that the channel funding should be sent to on close. Requires `opt_upfront_shutdownscript`
Allows us to more easily pass through args to `fundchannel` while still using the utility function's funding + open confirmation logics
We need this so we can verify the 'close_to' result
Since `fundchannel` now supports the 'close_to' argument, we can remove all the logic needed to call fundchannel_start here. Underneath, we're still calling `fundchannel_start`, we're just one (or two, if you count multifundchannel) call levels away from it now.
niftynei
force-pushed
the
nifty/fc-close-to
branch
from
41470af
to
9650a86
Compare
|
Ok, misplaced changes have been moved to the correct commits; FIXME has been additionally detailed. |
|
Ack 9650a86 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had
close_toavailable onfundchannel_startfor a while now. This wires it all the way through to generalfundchannelusers.