dual_open: correct silent enum conversions #4146
Conversation
channeld/channeld.c
Outdated
| case REMOTE: | ||
| role = TX_ACCEPTER; | ||
| break; | ||
| default: |
There was a problem hiding this comment.
FYI, adding a default totally undoes the reason for using a switch statement here, which is to fail to compile if/when the number of enums changes.
There was a problem hiding this comment.
There is already a third alternative (NUM_SIDE), the purpose of this switch was to assert that we are never passed NUM_SIDE (or, as unlikely as it could be, a new alternative value) since it does not make sense for the 2-alternatives enum.
There was a problem hiding this comment.
Yeah, NUM_SIDES should be a #define, not within the enum. This is the pattern we used elsewhere.
There was a problem hiding this comment.
Just checked this. NUM_SIDES is a #define, and has been since 2618ef1
niftynei
force-pushed
the
fix_silent_conversions
branch
from
6830218
to
aec52a2
Compare
channeld/channeld.c
Outdated
| case REMOTE: | ||
| role = TX_ACCEPTER; | ||
| break; | ||
| default: |
There was a problem hiding this comment.
Just checked this. NUM_SIDES is a #define, and has been since 2618ef1
niftynei
force-pushed
the
fix_silent_conversions
branch
from
aec52a2
to
51e7dcf
Compare
|
ACK 51e7dcf |
We were silently converting a side enum (3 variants) to a tx_role enum (2 variants). Signed-off-by: Antoine Poinsot <[email protected]>
darosior
force-pushed
the
fix_silent_conversions
branch
from
51e7dcf
to
1c3cb34
Compare
|
ACK 1c3cb34 Thanks for taking care of updating this. Had to rebase on master to build properly. |
|
Could someone restart https://travis-ci.org/github/ElementsProject/lightning/jobs/740598643 ? The failure seems (very) unrelated and I can no longer do it |
We were silently converting a side enum (3 variants) to a tx_role enum
(2 variants).
Signed-off-by: Antoine Poinsot [email protected]
Changelog-None