Direct inject update #4361
Merged
Direct inject update #4361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This overcomes the internal spam filter on updates, which can be useful if we're actually trying to send through such a node. Signed-off-by: Rusty Russell <[email protected]> Changelog-Fixed: Protocol: always accept channel_updates from errors, even they'd otherwise be rejected as spam. Fixes: ElementsProject#4300
rustyrussell
force-pushed
the
guilt/direct-inject-update
branch
from
4e7964a
to
c4b8e8e
Compare
cdecker
approved these changes
Feb 1, 2021
gossipd/gossipd.c
Outdated
| @@ -1706,6 +1707,7 @@ static struct io_plan *handle_txout_reply(struct io_conn *conn, | |||
| struct amount_sat sat; | |||
| bool good; | |||
|
|
|||
| status_debug("handle_txout_reply!"); | |||
There was a problem hiding this comment.
Is this used somewhere? Otherwise it's likely to confuse users.
|
|
||
| switch (fromwire_peektype(goss)) { | ||
| case WIRE_CHANNEL_ANNOUNCEMENT: | ||
| errmsg = handle_channel_announcement_msg(daemon, NULL, goss); |
There was a problem hiding this comment.
Had to verify that this still performs the chain_hash check, which is good, otherwise we could end up with some botched experiments :-)
Importantly, this is synchronous, so pay will be able to use it reliably. Signed-off-by: Rusty Russell <[email protected]>
Cut & paste from gossipd. Signed-off-by: Rusty Russell <[email protected]>
We fix up the test by using pay, instead of sendpay (and making pay log the expected message). Signed-off-by: Rusty Russell <[email protected]> Changelog-Changed: sendpay no longer extracts updates from errors, the caller should do it from the `raw_message`.
Signed-off-by: Rusty Russell <[email protected]> Changelog-Added: JSON-RPC: `addgossip` allows direct injection of network gossip messages.
rustyrussell
force-pushed
the
guilt/direct-inject-update
branch
from
c4b8e8e
to
9399fec
Compare
|
ACK 9399fec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes "pay" inject the update directly, and ensures gossipd doesn't suppress it. This removes some uncleanliness from inside lightningd, too.