channeld: don't ever send back-to-back feerate changes, fix feerate logic. #4480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
guilt/reduce-feerate-signature-disagreements
branch
from
04fc6d5
to
16ea05f
Compare
0e319b6
reviewed
Apr 18, 2021
|
Needs a nice changelog message :-) ACK 16ea05f |
rustyrussell
force-pushed
the
guilt/reduce-feerate-signature-disagreements
branch
from
16ea05f
to
f046c04
Compare
We don't always get two transactions on line 1019; the comment is confused (only one penalty tx successfully comes out of l3). So make sure we get the other transactions when we expect them, and then make this test more specific. Signed-off-by: Rusty Russell <[email protected]>
There are several reports of desynchronization with LND here; a simple approach is to only have one feerate change in flight at any time. Even if this turns out to be our fault, it's been a historic area of confusion, so this restriction seems reasonable. Changelog-Fixed: Protocol: Don't create more than one feerate change at a time, as this seems to desync with LND. Fixes: ElementsProject#4152 Signed-off-by: Rusty Russell <[email protected]>
By iterating through them forward, we would often increment them more than once! Always print feestate transitions, which is how I worked this out. Changelog-Fixed: Protocol: handle complex feerate transitions correctly. Signed-off-by: Rusty Russell <[email protected]>
This may have made our feestates fully resolved, so we can send update_fee again. Without this fix our tests sometimes timeout. Also add debugging so we can see when we suppressed a feechange. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/reduce-feerate-signature-disagreements
branch
from
f046c04
to
bf7947b
Compare
rustyrussell
changed the title
|
ACK bf7947b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several reports of desynchronizaion with LND here; a simple
approach is to only have one feerate change in flight at any time.
But I also found that our fee state machine was a bit screwed (thanks to CI flake!), so that may also have caused this problem.
Fixes: #4152