Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When opening, reserve inputs for 2016 blocks. #4510

Merged

Conversation

rustyrussell
Copy link
Contributor

We were only doing 72 (fundpsbt) + 72 (sendpsbt). This requires some extra infra to change the default.

@rustyrussell rustyrussell added this to the v0.10.1 milestone May 5, 2021
@rustyrussell rustyrussell requested a review from cdecker as a code owner May 5, 2021 07:31
@cdecker
Copy link
Member

cdecker commented May 25, 2021

1d57ea1 is bit strange, but I assume it is part of a larger debug session.

ACK 1d57ea1

We already have this field in reserveinputs and unreserveinputs.

Signed-off-by: Rusty Russell <[email protected]>
Changelog-Added: JSON-RPC: `listfunds` has a new `reserved_to_block` field.
@rustyrussell
Copy link
Contributor Author

1d57ea1 is bit strange, but I assume it is part of a larger debug session.

ACK 1d57ea1

Yes, will delete, and rebase...

…ustom number of blocks to reserve.

Not an API break: reserve=true|false still works for fundpsbt and utxopsbt,
but we also allow a raw number in there.

Signed-off-by: Rusty Russell <[email protected]>
…ours.

Signed-off-by: Rusty Russell <[email protected]>
Changelog-Changed: Plugins: `fundchannel` and `multifundchannel` will now reserve funding they use for 2 weeks instead of 12 hours.
@rustyrussell
Copy link
Contributor Author

Trivial rebase:

Ack aef30cf

@rustyrussell rustyrussell merged commit 14eddb9 into ElementsProject:master May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants