Update spec to latest changes #4556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of open-coding, use the helper. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/spec-update-htlc-msat-test-vectors
branch
from
c5163de
to
673d680
Compare
niftynei
approved these changes
May 25, 2021
rustyrussell
force-pushed
the
guilt/spec-update-htlc-msat-test-vectors
branch
from
673d680
to
68607c4
Compare
cdecker
force-pushed
the
guilt/spec-update-htlc-msat-test-vectors
branch
from
68607c4
to
93fcf81
Compare
rustyrussell
force-pushed
the
guilt/spec-update-htlc-msat-test-vectors
branch
2 times, most recently
from
bdc5cc1
to
4dfe41c
Compare
|
Rebase and fix for missing test change due to EXPERIMENTAL_FEATURES change: Ack dd53261 |
lightning/bolts#672 was merged. Signed-off-by: Rusty Russell <[email protected]> Changelog-Added: Protocol: `option_shutdown_anysegwit` allows future segwit versions on shutdown transactions.
As per lightning/bolts#872 Signed-off-by: Rusty Russell <[email protected]>
This includes anysegwit and the updated HTLC tiebreak test vector. It also adds explicit wording for invalid per_commitment_secret (which nicely matches our code already!). Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/spec-update-htlc-msat-test-vectors
branch
from
4dfe41c
to
dd53261
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, option_shutdown_anysegwit is no longer experimental!