Support the the filtering option by status in the listpays and listsendpays

[vincenzopalazzo]

This is a working in progress feature and it is a proposal to give the user to see the possibility to see the payment filtered by status.

Fixes #4588

• Support new propriety in the last command that is status
• Sanity check in the status propriety
• Adding a test to make sure that the filter option works
• Update docs

Signed-off-by: Vincenzo Palazzo [email protected]

[vincenzopalazzo]

The GitHub action failure seems unrelated https://github.com/ElementsProject/lightning/runs/2821322348?check_suite_focus=true#step:5:2397

It looks like related to #4551.

I retry to be lucky with GitHub actions, lets see 💺

[vincenzopalazzo]

I move it as a draft, we can wait for it the release is around the corner.

[vincenzopalazzo]

The failure in CI seems to be unrelated.

What do you think about the point refactoring in the wallet.c to make the if-else smaller and more readable @rustyrussell do your think that is a good refactoring in the wallet.c file?

I want to make an append operation from a default string before making the query. in this way, we have a smaller if-else, but I don't know if it is an antipattern in C

[vincenzopalazzo]

Rebased on top of master, and add missing fix around the code, like formatting fix and doc fixes

[cdecker]

The last commit needs to be removed, since at the raw DB layer we don't have the required context on the schema to even know if the field is nullable in the first place. There are several updates to the lnprototest submodule which I think are unwranted, could you filter those out?

Otherwise excellent proposal and rework 👍

[vincenzopalazzo]

There are several updates to the lnprototest submodule which I think are unwranted, could you filter those out?

@cdecker I think this message was referring to an old commit, I check the actual file change history and there are no lnprototest changes here, but I remember that I have a bad life some day ago with the lnprototest update.

There is other stuff there I need to do regarding to lnprototest?

[rustyrussell]

Ack 72c13d7