Autotor torport fix

[rustyrussell]

We were accidentally using the port that the tor service was connecting to, not the /torport the user said to use.

Fixes: #4597

[Saibato]

hmm... would that not also apply to autotor? I wonder what i reasoned about to use local->port and not port for static and blobs and autotor. Maybe some undesired privacy side effects?
I guess to demand defining the advertised and used port with /torport or to more precise the doc might also fix this.
Tor can be configured external bind to any port or the default and use only internal the local.
It should have been possible in the issue case to reach the node over 9735, obliviously we should not announce the intern port, hmm...

[vincenzopalazzo]

LGTM.

ack 5943319

[rustyrussell]

hmm... would that not also apply to autotor? I wonder what i reasoned about to use local->port and not port for static and blobs and autotor. Maybe some undesired privacy side effects?

Yes, this fix covers both.

I guess to demand defining the advertised and used port with /torport or to more precise the doc might also fix this.
Tor can be configured external bind to any port or the default and use only internal the local.
It should have been possible in the issue case to reach the node over 9735, obliviously we should not announce the intern port, hmm...

Yes, /torport was what we told Tor to listen on, but we didn't actually advertize that! So this is clearly wrong.