A little more offers #4630
Merged
A little more offers #4630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
guilt/more-offers
branch
2 times, most recently
from
4558609
to
e74fbc7
Compare
Signed-off-by: Rusty Russell <[email protected]>
We usually assume we're fetching an invoice we are going to pay, so we look up the previous payment for the payer key, and other sanity checks. This adds a developer option to fetchinvoice, which allows it to force its own payer key, which it uses to sign directly and bypasses these checks. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/more-offers
branch
from
e74fbc7
to
f9cb1f1
Compare
And fix up the mess we'd made: 1. We didn't order merkles by lesser-first. 2. We didn't correctly construct tree with last nodes on shortest path. Now we have tests! Signed-off-by: Rusty Russell <[email protected]> Changelog-EXPERIMENTAL: protocol: offer signature format changed.
The one about size needs the offers PR rebased onto the latest onion-message PR. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/more-offers
branch
from
f9cb1f1
to
ba23269
Compare
And add annotation so compiler spots it! Signed-off-by: Rusty Russell <[email protected]>
|
ACK 225a598 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First fix a crash where we decode a signatureless offer. Doh! Then add a developer-only option to override the fetchinvoice logic with a custom secret payer key.
Compat break with merkle (i.e. signature, offer_id) calculation