Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanups: stabilize tests and make sqlite version checks less aggressive #4852

Merged
merged 3 commits into from
Oct 11, 2021
Merged

Cleanups: stabilize tests and make sqlite version checks less aggressive #4852

merged 3 commits into from
Oct 11, 2021

Commits on Oct 10, 2021

  1. db: Ensure sqlite3 library minimum version and major version match 

    We were really strict with the version check, requiring an exact
match. We now check that we are running at least with the version we
were compiled with (distro upgrades continue to work, and repro builds
are built off of an unupdated installation matching this minimum
requirement), and a major version match (since major versions can and
will introduce breaking changes).

Changelog-Fixed: sqlite3: Relaxed the version match requirements to be at least a minimum version and a major version match
    @cdecker
    cdecker committed Oct 10, 2021
    Configuration menu
    Copy the full SHA
    7dfa101 View commit details
    Browse the repository at this point in the history

  2. pytest: Use the same TIMEOUT in wait_for_route 

    This was getting flaky whenever we had multihop routing syncs and had
`DEVELOPER=0`, which uses the slow gossip propagation.
    @cdecker
    cdecker committed Oct 10, 2021
    Configuration menu
    Copy the full SHA
    d2aa2b7 View commit details
    Browse the repository at this point in the history

  3. pyln: Add missing requirement from pyln-client to pyln-proto 

    Gossmap makes use of the proto, this ensures we have it.
    @cdecker
    cdecker committed Oct 10, 2021
    Configuration menu
    Copy the full SHA
    49ea770 View commit details
    Browse the repository at this point in the history