Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix out-of-sync sequence for psql and wrap destructor in optional DB transaction #4894

Merged
merged 3 commits into from
Oct 31, 2021
Merged

Fix out-of-sync sequence for psql and wrap destructor in optional DB transaction #4894

merged 3 commits into from
Oct 31, 2021

Conversation

cdecker
Copy link
Member

@cdecker cdecker commented Oct 29, 2021

Fixes #4887
Fixes #4879
Fixes #4891

@cdecker
db: Allow DB-specific queries in the migrations
26e2f4b 
Sometimes we need some DB-specific magic, and marking migrations with
`/*PSQL*/` or `/*SQLITE*/` will now give us that.
@cdecker
wallet: Re-sync the payments.id sequence with postgresql
305e456 
Fixes ElementsProject#4883
Fixes ElementsProject#4879
Changelog-None: Unreleased bug being fixed.
@cdecker
peer: Wrap the HTLC out destructor in a DB transaction
7f47315 
Changelog-Fixed: peer: Fixed a crash when a connection is lost outside of a DB transaction
@cdecker cdecker added this to the v0.10.2 milestone Oct 29, 2021
@cdecker cdecker requested a review from niftynei October 29, 2021 17:04
@cdecker cdecker self-assigned this Oct 29, 2021
This was referenced Oct 29, 2021
Closed
Closed
vincenzopalazzo
vincenzopalazzo approved these changes Oct 29, 2021
View reviewed changes
Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a good way to hook into the close event so we can wrap the cascade in a transaction as well? The alternative is to have a tiny wrapper around the destructor that just starts the DB transaction and commits it.

Concept ack, sorry for the missing in the issue #4891 answer.

ack 7f47315

rustyrussell
rustyrussell approved these changes Oct 30, 2021
View reviewed changes
Copy link
Contributor

@rustyrussell rustyrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack 7f47315

@cdecker cdecker merged commit 0351940 into ElementsProject:master Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincenzopalazzo vincenzopalazzo vincenzopalazzo approved these changes

@rustyrussell rustyrussell rustyrussell approved these changes

@niftynei niftynei Awaiting requested review from niftynei

Assignees

@cdecker cdecker

Labels
None yet
Projects
None yet
Milestone
v0.10.2
3 participants
@cdecker @rustyrussell @vincenzopalazzo