Update to latest bolts #5226
Merged
Update to latest bolts #5226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
added
gossip
protocol
This was eliminated this morning in the latest spec. We still accept them, we just don't produce them any more. Changelog-Removed: Protocol: We no longer create gossip messages which use zlib encoding (we still understand them, for now!) Signed-off-by: Rusty Russell <[email protected]>
We can simply start with a '0' where encoding is prefixed, so simplify internal interface. Signed-off-by: Rusty Russell <[email protected]>
This contains a typo fix and a clarification on channel_type, but also removes ZLIB. Signed-off-by: Rusty Russell <[email protected]>
Only affects comments. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/update-latest-bolt
branch
from
b4632cf
to
a633b8f
Compare
Now it's formatted properly, we don't need the patch. But we need to explicitly marshal/unmarshal into a byte stream, which involves some code rearrangement. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/update-latest-bolt
branch
from
a633b8f
to
46d4a27
Compare
|
OK, final one is a more significant change, needs @m-schmoock review please! |
m-schmoock
approved these changes
May 18, 2022
|
ACK 46d4a27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, this removes zlib-send support.