listforwards localfail out_channel #5330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
guilt/listforwards-localfail-out_channel
branch
from
dd8b6ba
to
af1e9a9
Compare
rustyrussell
force-pushed
the
guilt/listforwards-localfail-out_channel
branch
from
af1e9a9
to
d6e3d79
Compare
|
Rebase after scid aliases! |
…possible. Signed-off-by: Rusty Russell <[email protected]>
This (will) happen if they ask is to forward to an unknown scid. Signed-off-by: Rusty Russell <[email protected]>
They're not logically connected: we can know where they wanted to go, but we didn't send it. Where possible, it's the scid *they asked for*; otherwise, it's the scid or fallback to the alias, but do this in the *caller*, not by overriding inside wallet_forwarded_payment_add. Signed-off-by: Rusty Russell <[email protected]>
There's one case where we can present more infomation, so do that, and fix documentation. Changelog-Added: JSON-RPC: `listforwards` now shows `out_channel` in more cases: even if it couldn't actually send to it. Signed-off-by: Rusty Russell <[email protected]> Fixes: ElementsProject#5329
rustyrussell
force-pushed
the
guilt/listforwards-localfail-out_channel
branch
from
d6e3d79
to
fdc3305
Compare
|
Fixed final patch: we can't set hout in db if it does not exist, as we get "Foreign constraint failed". |
rustyrussell
force-pushed
the
guilt/listforwards-localfail-out_channel
branch
from
fdc3305
to
090044a
Compare
|
Rebased again, removed unrelated fixup which clashed with master rebase. |
|
ACK 090044a lgtm, test failure is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are more cases where we can populate out_channel; we definitely need to fix the case where we failed locally because the outgoing channel didn't have capacity, but we should also try anywhere that they gave us a channel to fwd to, even if it doesn't exist, for example.