Commits on Jul 6, 2022

1. ccan: update to latest htable fixes, and update gossmap to meet new a… …

   …ssertions.
   
   Updating ccan to stricter htable revealed we were trying to put
   (void *)1 in the htable, which is forbidden:
   
   ```
   topology: ccan/ccan/htable/htable.c:382: htable_add_: Assertion `entry_is_valid((uintptr_t)p)' failed.
   topology: FATAL SIGNAL 6 (version 1358d7f)
   0x55f30c689c34 send_backtrace
   	common/daemon.c:33
   0x55f30c689ce0 crashdump
   	common/daemon.c:46
   0x7f5d150fe51f ???
   	./signal/../sysdeps/unix/sysv/linux/x86_64/libc_sigaction.c:0
   0x7f5d15152828 __pthread_kill_implementation
   	./nptl/pthread_kill.c:44
   0x7f5d15152828 __pthread_kill_internal
   	./nptl/pthread_kill.c:80
   0x7f5d15152828 __GI___pthread_kill
   	./nptl/pthread_kill.c:91
   0x7f5d150fe475 __GI_raise
   	../sysdeps/posix/raise.c:26
   0x7f5d150e47b6 __GI_abort
   	./stdlib/abort.c:79
   0x7f5d150e46da __assert_fail_base
   	./assert/assert.c:92
   0x7f5d150f5e25 __GI___assert_fail
   	./assert/assert.c:101
   0x55f30c6adbe4 htable_add_
   	ccan/ccan/htable/htable.c:382
   0x55f30c65f303 chanidx_htable_add
   	common/gossmap.c:35
   0x55f30c6605ed new_channel
   	common/gossmap.c:337
   0x55f30c6609cf add_channel
   	common/gossmap.c:425
   0x55f30c661101 map_catchup
   	common/gossmap.c:607
   0x55f30c66221e gossmap_refresh
   	common/gossmap.c:927
   0x55f30c66e3e9 get_gossmap
   	plugins/topology.c:27
   0x55f30c66f939 listpeers_done
   	plugins/topology.c:369
   0x55f30c671f46 handle_rpc_reply
   	plugins/libplugin.c:558
   0x55f30c672a19 rpc_read_response_one
   	plugins/libplugin.c:726
   0x55f30c672b4f rpc_conn_read_response
   	plugins/libplugin.c:746
   0x55f30c6ae35e next_plan
   	ccan/ccan/io/io.c:59
   0x55f30c6aef93 do_plan
   	ccan/ccan/io/io.c:407
   0x55f30c6aefd5 io_ready
   	ccan/ccan/io/io.c:417
   0x55f30c6b1371 io_loop
   	ccan/ccan/io/poll.c:453
   0x55f30c67587c plugin_main
   	plugins/libplugin.c:1559
   0x55f30c6708eb main
   	plugins/topology.c:701
   0x7f5d150e5fcf __libc_start_call_main
   	../sysdeps/nptl/libc_start_call_main.h:58
   0x7f5d150e607c __libc_start_main_impl
   	../csu/libc-start.c:409
   0x55f30c65d894 ???
   	???:0
   0xffffffffffffffff ???
   	???:0
   ```
   
   Signed-off-by: Rusty Russell <[email protected]>

   

   rustyrussell committed Jul 6, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 1f6c94f
   • Browse repository at this point

   Copy the full SHA

   1f6c94f View commit details

   Browse the repository at this point in the history

2. channeld: fix uninitializes scid alias for dual-funding. …

   Caused a crash in CI, reproduced under valgrind by calling
   any_channel_by_scid from io_poll_lightningd:
   
   ```
   ==2422524== Conditional jump or move depends on uninitialised value(s)
   ==2422524==    at 0x12C98D: any_channel_by_scid (channel.c:606)
   ==2422524==    by 0x14FF75: io_poll_lightningd (lightningd.c:682)
   ==2422524==    by 0x225FDE: io_loop (poll.c:420)
   ==2422524==    by 0x14A914: io_loop_with_timers (io_loop_with_timers.c:22)
   ==2422524==    by 0x150C4E: main (lightningd.c:1193)
   ==2422524==  Uninitialised value was created by a heap allocation
   ==2422524==    at 0x483B7F3: malloc (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)
   ==2422524==    by 0x234F61: allocate (tal.c:250)
   ==2422524==    by 0x235522: tal_alloc_ (tal.c:428)
   ==2422524==    by 0x12B500: new_unsaved_channel (channel.c:203)
   ==2422524==    by 0x13B77A: json_openchannel_init (dual_open_control.c:2610)
   ==2422524==    by 0x14C78D: command_exec (jsonrpc.c:630)
   ==2422524==    by 0x14CD9F: rpc_command_hook_final (jsonrpc.c:765)
   ==2422524==    by 0x181DDA: plugin_hook_call_ (plugin_hook.c:278)
   ==2422524==    by 0x14D198: plugin_hook_call_rpc_command (jsonrpc.c:853)
   ==2422524==    by 0x14D6A0: parse_request (jsonrpc.c:957)
   ==2422524==    by 0x14DAFE: read_json (jsonrpc.c:1054)
   ==2422524==    by 0x2231C8: next_plan (io.c:59)
   ```
   
   Signed-off-by: Rusty Russell <[email protected]>

   

   rustyrussell committed Jul 6, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 388742d
   • Browse repository at this point

   Copy the full SHA

   388742d View commit details

   Browse the repository at this point in the history