notify: channel_state_changed now receives notice when channel opens
#5381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niftynei
force-pushed
the
nifty/state_change_on_open
branch
from
e731b26
to
9c8c9d9
Compare
cdecker
force-pushed
the
nifty/state_change_on_open
branch
from
9c8c9d9
to
f131714
Compare
|
Rebased on top of ACK f131714 |
Previously we wouldn't notify when a channel moves into state "CHANNELD_AWAITING_LOCKIN", as this is the original state (so there's no movement btw states). This meant that it's impossible to track when a channel's commitment txs have been exchanged and we're waiting for onchain confirmation. It's useful to have notice of this initialization though, all in one place so that the `channel_state_changed` notification can successfully track the entire lifecycle of a channel, from inception to close. Note that for v2 "dual-funded" channels, we already notify at the same place, at "DUALOPEND_AWAITING_LOCKIN" (the initial state for a dualopend channel is "DUALOPEND_OPEN_INIT" -- this is the only state we don't get notified at now...) Changelog-Added: Plugins: `channel_state_changed` now triggers for a v1 channel's initial "CHANNELD_AWAITING_LOCKIN" state transition (from prior state "unknown")
niftynei
force-pushed
the
nifty/state_change_on_open
branch
from
f131714
to
ae80d5e
Compare
|
re-applying ACK ae80d5e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we wouldn't notify when a channel moves into state
"CHANNELD_AWAITING_LOCKIN", as this is the original state (so there's
no movement btw states). This meant that it's impossible to track when a
channel's commitment txs have been exchanged and we're waiting for
onchain confirmation.
It's useful to have notice of this initialization though, all in one
place so that the
channel_state_changednotification can successfullytrack the entire lifecycle of a channel, from inception to close.
Note that for v2 "dual-funded" channels, we already notify at the same place, at
"DUALOPEND_AWAITING_LOCKIN" (the initial state for a dualopend channel
is "DUALOPEND_OPEN_INIT" -- this is the only state we don't get notified
at now...)
Changelog-Added: Plugins:
channel_state_changednow triggers for a v1 channel's initial "CHANNELD_AWAITING_LOCKIN" state transition (from prior state "unknown")