Feature neatening

[rustyrussell]

We didn't set option_channel_type and AFAICT we should (and should have since v0.10.2?).

Fixes: #5500

[vincenzopalazzo]

looks like the CI catch a crash?

lightning_channeld: Could not set sync read from master: Connection reset by peer (version 788e62b)
Lost connection to the RPC socket.
Lost connection to the RPC socket.
Lost connection to the RPC socket.
Lost connection to the RPC socket.
Lost connection to the RPC socket.
Lost connection to the RPC socket.
Lost connection to the RPC socket.
Lost connection to the RPC socket.
0x55766834851f send_backtrace
	common/daemon.c:33
0x55766835d11f status_failed
	common/status.c:221
0x55766832fd7b master_wait_sync_reply
	channeld/channeld.c:983
0x557668332ed9 handle_peer_revoke_and_ack
	channeld/channeld.c:1877
0x557668333de4 peer_in
	channeld/channeld.c:2254
0x557668337fb4 main
	channeld/channeld.c:4097
0x7fa39c74f082 __libc_start_main
	../csu/libc-start.c:308
0x55766832dd6d ???
	???:0
0xffffffffffffffff ???
	???:0
Plugin '/home/runner/work/lightning/lightning/tests/plugins/dblog.py' returned an invalid response to the db_write hook: {"jsonrpc": "2.0", "id": 40, "error": {"code": -32600, "message": "Error while processing db_write: UNIQUE constraint failed: shachain_known.shachain_id, shachain_known.pos", "traceback": "Traceback (most recent call last):\n  File \"/home/runner/work/lightning/lightning/contrib/pyln-client/pyln/client/plugin.py\", line 631, in _dispatch_request\n    result = self._exec_func(method.func, request)\n  File \"/home/runner/work/lightning/lightning/contrib/pyln-client/pyln/client/plugin.py\", line 616, in _exec_func\n    return func(*ba.args, **ba.kwargs)\n  File \"/home/runner/work/lightning/lightning/tests/plugins/dblog.py\", line 45, in db_write\n    plugin.conn.execute(c)\nsqlite3.IntegrityError: UNIQUE constraint failed: shachain_known.shachain_id, shachain_known.pos\n"}}
lightningd: FATAL SIGNAL 6 (version 788e62b)
0x55928732b1c6 send_backtrace
	common/daemon.c:33
0x55928732b270 crashdump
	common/daemon.c:46
0x7f1526ce508f ???
	/build/glibc-SzIz7B/glibc-2.31/signal/../sysdeps/unix/sysv/linux/x86_64/sigaction.c:0
0x7f1526ce500b __GI_raise
	../sysdeps/unix/sysv/linux/raise.c:51
0x7f1526cc4858 __GI_abort
	/build/glibc-SzIz7B/glibc-2.31/stdlib/abort.c:79
0x5592872cc5a0 fatal_vfmt
	lightningd/log.c:850
0x5592872cc655 fatal
	lightningd/log.c:858
0x5592872fb922 db_hook_response
	lightningd/plugin_hook.c:306
0x5592872f54e7 plugin_response_handle
	lightningd/plugin.c:591
0x5592872f5746 plugin_read_json_one
	lightningd/plugin.c:702
0x5592872f592a plugin_read_json
	lightningd/plugin.c:747
0x55928741702a next_plan
	ccan/ccan/io/io.c:59
0x559287417c32 do_plan
	ccan/ccan/io/io.c:407
0x559287417c74 io_ready
	ccan/ccan/io/io.c:417
0x559287419f67 io_loop
	ccan/ccan/io/poll.c:453
0x5592872f9af8 plugins_exclusive_loop
	lightningd/plugin.c:2093
0x5592872fbd52 plugin_hook_db_sync
	lightningd/plugin_hook.c:393
0x55928738f9bd db_report_changes
	db/utils.c:207
0x55928734d08b db_commit_transaction
	db/exec.c:150
0x5592872ff588 sd_msg_read
	lightningd/subd.c:585
0x55928741702a next_plan
	ccan/ccan/io/io.c:59
0x559287417c32 do_plan
	ccan/ccan/io/io.c:407
0x559287417c74 io_ready
	ccan/ccan/io/io.c:417
0x559287419f67 io_loop
	ccan/ccan/io/poll.c:453
0x5592872c3555 io_loop_with_timers
	lightningd/io_loop_with_timers.c:22
0x5592872c9442 main
	lightningd/lightningd.c:1194
0x7f1526cc6082 __libc_start_main
	../csu/libc-start.c:308
0x55928729d38d ???
	???:0
0xffffffffffffffff ???
	???:0
Log dumped in crash.log.20220724064920
lightning_channeld: Could not set sync read from master: Connection reset by peer (version 788e62b)

[rustyrussell]

Real issue is here:

Plugin '/home/runner/work/lightning/lightning/tests/plugins/dblog.py' returned an invalid response to the db_write hook: {"jsonrpc": "2.0", "id": 40, "error": {"code": -32600, "message": "Error while processing db_write: UNIQUE constraint failed: shachain_known.shachain_id, shachain_known.pos", "traceback": "Traceback (most recent call last):\n File "/home/runner/work/lightning/lightning/contrib/pyln-client/pyln/client/plugin.py", line 631, in _dispatch_request\n result = self._exec_func(method.func, request)\n File "/home/runner/work/lightning/lightning/contrib/pyln-client/pyln/client/plugin.py", line 616, in _exec_func\n return func(*ba.args, **ba.kwargs)\n File "/home/runner/work/lightning/lightning/tests/plugins/dblog.py", line 45, in db_write\n plugin.conn.execute(c)\nsqlite3.IntegrityError: UNIQUE constraint failed: shachain_known.shachain_id, shachain_known.pos\n"}}

Ah, this actually expected: because the test kills l2, it is possible that the db hasn't been committed by lightningd, but has by the plugin. Then it fails.

Found another bug though....

[niftynei]

ACK 9e0966b