Fix for #5557 #5587
Merged
Fix for #5557 #5587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reproduce crash for ElementsProject#5557! If we record the channel open because bookkeeper was added after the channel open request started but the channel confirms later, we end up with re-recording any associated push or leased fees (paid or rcvd). In the case where you've paid for these fees, your channel balance goes negative and the node crashes the next time you call `listbalances`. Reported-by: @chrisguida
We were double counting channel lease fees because we were double firing the channel open event sequence (so to speak). If we don't report balances for unopened channels, we don't have this problem? Changelog-Changed: Plugins: `balance_snapshot` notification does not send balances for channels that aren't locked-in/opened yet
Clean up for ElementsProject#5557. If you've got duplicate 'lease_fee' entries, we delete them!
Make sure that we're not issuing duplicate lease_fee events!
test_bookkeeping_closing_trimmed_htlcs fails to find 'all outputs resolved' occassionally, seems like it's because the OUR_DELAYED_TO_WALLET doesn't make it into the mempool before we start mining blocks? So here make sure there's something in the mempool before before we start making new blocks.
niftynei
force-pushed
the
nifty/bkpr-bugs
branch
from
b7a44ff
to
3e903e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crash found in
bookkeeperaround duplicate lease_fees! Here we fix them.