Fix deschash escaped json #6337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenzopalazzo
previously requested changes
Jun 19, 2023
rustyrussell
force-pushed
the
fix-deschash-escaped-json
branch
from
a2bdbf0
to
941dea8
Compare
rustyrussell
dismissed
vincenzopalazzo’s stale review
Rebased on master, those commits are gone
rustyrussell
force-pushed
the
fix-deschash-escaped-json
branch
from
941dea8
to
fe37dfc
Compare
…ashed descriptions. This means we need to push off requring this for another full deprecation cycle! Signed-off-by: Rusty Russell <[email protected]> Changelog-Fixed: JSON-RPC: `pay` and `decodepay` with description now correctly handle JSON escapes (e.g " inside description)
Since we didn't hash the descriptions properly (see previous commit), we cannot immediately deprecate omitting the descriptions (since you'd have to omit them for backwards compat!). And move the "must have description or hash" test into bolt11.c core. Changelog-Deprecated: `pay` has *undeprecated* paying a description-hash invoice without providing the description. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
fix-deschash-escaped-json
branch
from
fe37dfc
to
927db5c
Compare
|
That silent SIGTERM failure is weird. Maybe we're running oom? Will debug tomorrow... |
It seems to reliably be getting a SIGTERM after 17-18 minutes: ``` [gw1] [ 91%] PASSED tests/test_plugin.py::test_forward_event_notification Error: Process completed with exit code 143. ``` Perhaps this is out of mem? So, try -n2. We also make the configure line explicit, rather than relying on environment vars (we should probably do this for the other cases, too) Signed-off-by: Rusty Russell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6085
Notably, since our deschash comparison was broken, we cannot insist people provide a description, so back off on that deprecation.