Reckless: support additional installation sources #6393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endothermicdev
force-pushed
the
reckless-multisource-install
branch
from
93e33c5
to
ac5ceb6
Compare
rustyrussell
force-pushed
the
reckless-multisource-install
branch
from
ac5ceb6
to
7be3008
Compare
|
Trivial rebase on master, hoping that helps CI |
|
@endothermicdev needs disabling some tests on elements? |
endothermicdev
force-pushed
the
reckless-multisource-install
branch
2 times, most recently
from
f73bba5
to
7f1ae67
Compare
|
Should be okay on elements - but I did change the debug output and forgot to update the test. Fixed that and realized there should be a test for a local install from directory source. I can squash the new commit if you'd prefer. |
Abstracts search and directory traversal. Adds support for installing from a local git repository, a local directory, or a web hosted git repo without relying on an api. Changelog-Changed: Reckless can now install directly from local sources.
endothermicdev
force-pushed
the
reckless-multisource-install
branch
from
7f1ae67
to
f50f866
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds abstractions to the search and directory traversal so that additional installation sources can be used. It supports local git repositories, local directories, and web hosted git repos beyond github (does not require an api.) Needs some squashing.