dual-fund: tx-abort fixups #6461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way unreserving the PSBT will work as intended, and we don't have to keep track of how many times we've called reserved for any one input. Technically we're supposed to not reserve inputs at *all* while doing opens, this moves us slightly closer to that.
Bug Report: - initiate a channel open eclair -> cln - wait for the transaction to be published - eclair initiates rbf, and cancels it by sending tx_abort before exchanging commit_sig - at that point everything looks good, cln echoes the tx_abort and stays connected - eclair initiates another RBF attempt and sends tx_init_rbf: for some unknown reason, cln answers with channel_reestablish (??) followed by an error saying "Bad reestablish message: WIRE_TX_INIT_RBF" Diagnosis: CLN is doing a reconnect after a tx-abort is sent. Extra Test: Realized that if we abort, we won't correctly advanced to NORMAL if blocks are mined while we're in hanging state. CLN should advance after block containing channel open is mined. Reported-By: @t-bast
Clean restart of daemon after a tx-abort is a nice way to work around the 'persistent' disconnect that we t-bast noticed. Changelog-Fixed: `dualopend`: Fix behavior for tx-aborts. No longer hangs, appropriately continues re-init of RBF requests without reconnction msg exchange.
|
I've tested this e2e against eclair, it's all good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by @t-bast from cross-compat with the Eclair dual-funding implementation.
Now we re-init the dualopend daemon when closed from an 'abort'. Seems to work very nicely?
Also fixes a problem where the channel won't advance to "NORMAL" if aborted on a subsequent RBF attempt.
Also fix bug where the
funderwould increase the reservation on RBFs of already reserved utxos, which then led to us not unreserving them on open failure. It's a halfway move towards us not reserving utxos at all during the negotiation phase of a channel open.